Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Iran holidays #1202

Closed
arkid15r opened this issue May 18, 2023 · 8 comments
Closed

Add Iran holidays #1202

arkid15r opened this issue May 18, 2023 · 8 comments

Comments

@arkid15r
Copy link
Collaborator

Links:

@xmha97
Copy link

xmha97 commented May 28, 2023

Hi @arkid15r
This is a list of Iranian holidays (en-IR),

Based on the official document:
https://calendar.ut.ac.ir/Fa/News/Data/Doc/Calendar%201402.pdf

Used Google Calendar translation:
https://calendar.google.com/calendar/embed?src=en.ir%23holiday%40group.v.calendar.google.com
https://calendar.google.com/calendar/ical/en.ir%23holiday%40group.v.calendar.google.com/public/basic.ics

# Title Day Month Calendar
1 Revolution Day 2 11 Gregorian
2 Oil Nationalization Day 3 20 Gregorian
3 Norooz (Persian New Year) 3 21 Gregorian
4 Norooz Holiday 3 22 Gregorian
5 Norooz Holiday 3 23 Gregorian
6 Norooz Holiday 3 24 Gregorian
7 Islamic Republic Day 4 1 Gregorian
8 Nature Day 4 2 Gregorian
9 Demise of Imam Khomeini 6 4 Gregorian
10 Khordad National Uprising 6 5 Gregorian
11 Tassoua 1 9 Islamic
12 Ashura 1 10 Islamic
13 Arbaeen 2 20 Islamic
14 Demise of Prophet Muhammad and Martyrdom of Imam Hassan 2 28 Islamic
15 Martyrdom of Imam Reza 2 29 Islamic
16 Martyrdom of Imam Hasan al-Askari 3 8 Islamic
17 Birthday of Prophet Muhammad and Imam Sadeq 3 17 Islamic
18 Martyrdom of Hazrat Fatima 6 3 Islamic
19 Birthday of Imam Ali and Father's Day 7 13 Islamic
20 Prophet's Ascension 7 27 Islamic
21 Imam Mahdi's birthday 8 15 Islamic
22 Martyrdom of Imam Ali 9 21 Islamic
23 Eid-e-Fetr (End of Ramadan) 10 1 Islamic
24 Eid-e-Fetr (Additional Holiday) 10 2 Islamic
25 Martyrdom of Imam Sadeq 10 25 Islamic
26 Eid-e-Ghorban (Feast of Sacrifice) 12 10 Islamic
27 Eid-e-Ghadir 12 18 Islamic

(Download JSON version: fa-IR.json)

@arkid15r
Copy link
Collaborator Author

Thanks for sharing this @xmha97!

@xmha97
Copy link

xmha97 commented May 29, 2023

Thanks for sharing this @xmha97!

@arkid15r You're welcome.
But note that some events in Iran are based on the Gregorian calendar and others are based on the Islamic calendar.

@xmha97
Copy link

xmha97 commented May 29, 2023

In addition, can I add events of Iran in Persian language (fa-IR)?
I haven't used your library yet and I don't know if it has language capability or not.

@arkid15r
Copy link
Collaborator Author

But note that some events in Iran are based on the Gregorian calendar and others are based on the Islamic calendar.

Yeah, that's fine. We have countries that use multiple calendars for their holidays.

In addition, can I add events of Iran in Persian language (fa-IR)?
I haven't used your library yet and I don't know if it has language capability or not.

Yes, it's possible to localize holiday names. The original holiday names should (preferably) be in country's official language which I believe fa_IR actually is.

@xmha97
Copy link

xmha97 commented May 30, 2023

Yes, it's possible to localize holiday names.

This is great. 👍
In what format should I send events? I need a template.
Do you agree with posting a comment on this issue?

@arkid15r
Copy link
Collaborator Author

Normally, when a person volunteers to add a new country holidays support it goes straight to the library code of the new country (see #1168 as one of the most recent examples). If a country support has already been implemented the l10n process requires regular .po files like this one. You can find some additional info here.

Posting the original holiday names here would of course be appreciated but does not guaranty adding them to the python-holidays until somebody implements the code.

I hope I interpreted your questions correctly.

@KJhellico KJhellico mentioned this issue Aug 3, 2023
13 tasks
@arkid15r
Copy link
Collaborator Author

Implemented in #1409

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants