Add Brunei Darussalam holidays

[PPsyrius]

Proposed change

Add Brunei holidays (en_US, ms, th localization).

Closes #1157. Currently waiting until a decision on #1140 and #1148 is made.

Type of change

• New country/market holidays support (thank you!)
• Supported country/market holidays update (calendar discrepancy fix, localization)
• Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
• Dependency upgrade (version update)
• Bugfix (non-breaking change which fixes an issue)
• Breaking change (a code change causing existing functionality to break)
• New feature (new python-holidays functionality in general)

Checklist

• I've followed the contributing guidelines
• This PR is filed against beta branch of the repository
• This PR doesn't contain any merge conflicts and has clean commit history
• The code style looks good: make pre-commit
• All tests pass locally: make test, make tox (we strongly encourage adding tests to your code)
• The related documentation has been added/updated (check off the box for free if no updates is required)

[PPsyrius]

I'm tackling these 2 errors so far to no avail:

______________ ERROR at setup of TestBrunei.test_armed_forces_day ______________
[gw0] linux -- Python 3.9.16 /opt/hostedtoolcache/Python/3.9.16/x64/bin/python

cls = <class 'tests.countries.test_brunei.TestBrunei'>

    @classmethod
    def setUpClass(cls):
>       super().setUpClass(
            Brunei,
            years=range(1984, 2077),
            years_non_observed=range(1984, 2077),
        )

tests/countries/test_brunei.py:19: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
tests/common.py:48: in setUpClass
    cls.holidays = test_class(years=years)
holidays/countries/brunei.py:73: in __init__
    super().__init__(*args, **kwargs)
holidays/holiday_base.py:327: in __init__
    self._populate(year)
holidays/countries/brunei.py:109: in _populate
    _add_observed(self._add_isra_and_miraj_day(tr("Israk dan Mikraj")))
holidays/countries/brunei.py:85: in _add_observed
    if self.observed and (self._is_friday(dt) or self._is_sunday(dt)):
holidays/holiday_base.py:842: in _is_friday
    return self._check_weekday(FRI, *args)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = {datetime.date(2048, 1, 1): 'Awal Tahun Masihi', datetime.date(2048, 2, 14): 'Tahun Baru Cina', datetime.date(2048, 2, 15): 'Tahun Baru Cina - Diperhatikan', datetime.date(2048, 5, 10): 'Israk dan Mikraj* (*angarran)'}
weekday = 4, args = ({datetime.date(2048, 5, 10)},)
dt = {datetime.date(2048, 5, 10)}

    def _check_weekday(self, weekday: int, *args) -> bool:
        """
        Returns True if `weekday` equals to the date's week day.
        Returns False otherwise.
        """
        dt = args[0] if len(args) == 1 else date(self._year, *args)
>       return dt.weekday() == weekday
E       AttributeError: 'set' object has no attribute 'weekday'

holidays/holiday_base.py:827: AttributeError

___________________ TestEntityLoader.test_countries_imports ____________________
[gw0] linux -- Python 3.9.16 /opt/hostedtoolcache/Python/3.9.16/x64/bin/python

self = <tests.test_registry.TestEntityLoader testMethod=test_countries_imports>

    def test_countries_imports(self):
        warnings.simplefilter("ignore")
    
        import holidays
    
        loader_entities = set()
        for module, entities in registry.COUNTRIES.items():
            module = importlib.import_module(f"holidays.countries.{module}")
            for entity in entities:
>               countries_cls = getattr(countries, entity)
E               AttributeError: module 'holidays.countries' has no attribute 'Brunei'

tests/test_registry.py:31: AttributeError

[arkid15r]

AttributeError: module 'holidays.countries' has no attribute 'Brunei'

It seems that the country hasn't been added to countries/__init__.py. Could you check this one?

[PPsyrius]

AttributeError: module 'holidays.countries' has no attribute 'Brunei'

It seems that the country hasn't been added to countries/__init__.py. Could you check this one?

Fixed now, thanks for the help :)

[KJhellico]

LGTM ✌️

[arkid15r]

This would be a great addition to the list of supported countries!
Thanks for all your work @PPsyrius!

Please let me know if you have any questions regarding the comments I've left:

[PPsyrius]

If I understand the problem correctly you're looking for something like:

self._add_islamic_calendar_holiday(
    self.tr("%s - Diperhatikan") % self[hol_date],
    (
        (
            obs_date,
            self._year
            not in BruneiIslamicCalendar.EID_AL_FITR_DATES,
        ),
    ),
)

@arkid15r Can you explain more about this? This is supposed to fully replace all instances of _add_observed(dt) in

for dt in self._add_eid_al_adha_day(tr("Hari Raya Aidil Adha")):
    _add_observed(dt)

and placed at the back once all Islamic holidays are already declared, right?

[arkid15r]

@arkid15r Can you explain more about this?

Sure -- the code example is a reply to the @KJhellico's comment you had during the review. It supposed to address the mentioned issue w/ Eid al-Fitr holiday (that might not be the problem any longer in your current code if observed/estimated holidays get labeled correctly):

This way, Eid al-Fitr (Observed) will never be labeled as "estimated", regardless of the origin of the date (exact or not). But unfortunately, I don't know of a good way to avoid it now. 🤷‍♂️

[arkid15r]

A couple more comments to address and we're good to go:

[arkid15r]

Great work 👍

Marking as ready for beta

[KJhellico]

Thank you for the contribution!