-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add arrow overlay part and theme variant to vaadin-popover #7550
Conversation
6c1453a
to
f5dea82
Compare
@@ -59,6 +59,8 @@ export const PopoverOverlayMixin = (superClass) => | |||
return; | |||
} | |||
|
|||
this.removeAttribute('arrow-centered'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: I'm not sure why it's only needed for horizontal positions. I tested vertical positions and they magically work without this attribute. I would appreciate a brief explanation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a result of different logic for start
and end
vertical positions where we always center the overlay. This aligns with how vaadin-tooltip
positions work, although I don't remember why it was done this way.
Updated to rename from |
f5dea82
to
ed2252c
Compare
Quality Gate passedIssues Measures |
This ticket/PR has been released with Vaadin 24.5.0.alpha6 and is also targeting the upcoming stable 24.5.0 version. |
Description
Added
theme="pointer-arrow"
to Lumo and Material which allows to show an arrow.The arrow placement is adjusted accordingly to the overlay position change.
For example, when using
top
position, the overlay can be re-positioned like this:popover-arrow.mp4
This includes adding the following styling API on the
vaadin-popover-overlay
:arrow
stylable shadow part (could also be a pseudo-element onoverlay
part)--vaadin-popover-arrow-size
custom CSS property (defaults to 0.5rem)arrow-centered
attribute set when we need to center the arrow horizontallyType of change