feat: add PopoverVariant enum with the arrow variant #6499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
force-pushed
the
feat/popover-variant
branch
2 times, most recently
from
0bf7c6d
to
f38b1c0
Compare
vursen
reviewed
Aug 5, 2024
|
|
||
| private final String variant; | ||
|
|
||
| PopoverVariant(String variant) { |
There was a problem hiding this comment.
I think we don't have tests for other variant enums, not sure how to test this one.
web-padawan
force-pushed
the
feat/popover-variant
branch
from
ba093c1
to
a886332
Compare
sissbruecker
reviewed
Aug 8, 2024
...rent/vaadin-popover-flow/src/main/java/com/vaadin/flow/component/popover/PopoverVariant.java
Outdated
Show resolved
Hide resolved
...rent/vaadin-popover-flow/src/main/java/com/vaadin/flow/component/popover/PopoverVariant.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Sascha Ißbrücker <[email protected]>
sissbruecker
approved these changes
Aug 8, 2024
vursen
approved these changes
Aug 8, 2024
|
|
This ticket/PR has been released with Vaadin 24.5.0.alpha9 and is also targeting the upcoming stable 24.5.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Based on vaadin/web-components#7550
Note: the
arrowvariant is available for both Lumo and Material.Type of change