refactor!: make reveal button extend vaadin-button #3167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
web-padawan
commented
Dec 9, 2021
|
|
||
| revealButton.dispatchEvent(e); | ||
| expect(e.defaultPrevented).to.be.true; | ||
| const event1 = makeSoloTouchEvent('touchend', null, revealButton); |
There was a problem hiding this comment.
As we use gesture events in vaadin-button, a manually created CustomEvent was causing errors.
web-padawan
commented
Dec 9, 2021
Comment on lines
+30
to
+32
| :host::after { | ||
| display: none; | ||
| } |
There was a problem hiding this comment.
I had to set overflow: visible in order to let the scale(1.5) styles work properly.
This caused the ripple to be very wide, so for now I decided to disable it 🙈
tomivirkki
approved these changes
Dec 9, 2021
36 tasks
|
This ticket/PR has been released with platform 23.0.0.alpha1 and is also targeting the upcoming stable 23.0.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaced
buttonelement withvaadin-password-field-buttonin order to leveragefocus-ringstyles.Note, the "eye" icon itself used to show the button is still where it was (
[part="reveal-button"]).Fixes #3139
Type of change