Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[password-field] Update reveal button to extend Button and set outline using focus-ring #3139

Closed
web-padawan opened this issue Dec 1, 2021 · 0 comments · Fixed by #3167
Closed

[password-field] Update reveal button to extend Button and set outline using focus-ring #3139

web-padawan opened this issue Dec 1, 2021 · 0 comments · Fixed by #3167
Assignees
@web-padawan
Labels
a11y phase 2 Candidates for a second batch of a11y fixes a11y Accessibility issue

Comments

@web-padawan
Copy link
Member

Problem

The password reveal button in <vaadin-password-field> has the focus outline visible when clicking due to :focus usage.

Screenshot 2021-11-26 at 12 15 52

Proposed solution

Replace button with vaadin-password-field-reveal-button that can extend vaadin-button.
@web-padawan web-padawan added a11y Accessibility issue a11y phase 2 Candidates for a second batch of a11y fixes labels Dec 1, 2021
@web-padawan web-padawan self-assigned this Dec 1, 2021
@web-padawan web-padawan mentioned this issue Dec 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@web-padawan web-padawan

Labels
a11y phase 2 Candidates for a second batch of a11y fixes a11y Accessibility issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor!: make reveal button extend vaadin-button vaadin/web-components
1 participant
@web-padawan