refactor: prevent page scrolling when resizing text area (CP: 21) #2444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change prevents the page from scrolling while the text area is measuring its height as part of the auto resize feature, when entering or removing text into the textarea. Cherry pick of: vaadin/vaadin-text-field#581 Rollback of changes from: #2143
web-padawan
reviewed
Sep 3, 2021
web-padawan
reviewed
Sep 3, 2021
web-padawan
reviewed
Sep 3, 2021
packages/vaadin-text-field/theme/material/vaadin-text-area-styles.js
Outdated
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed!
|
web-padawan
approved these changes
Sep 3, 2021
vaadin-bot
pushed a commit
that referenced
this pull request
Sep 3, 2021
web-padawan
pushed a commit
that referenced
this pull request
Sep 3, 2021
Co-authored-by: Sascha Ißbrücker <[email protected]>
|
This ticket/PR has been released with platform 21.0.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change prevents the page from scrolling while the text area is measuring its height as part of the auto resize feature, when entering or removing text into the textarea.
Cherry pick of: vaadin/vaadin-text-field#581
Rollback of changes from: #2143
Tagged as refactor, as this just replaces the previous fix.