refactor: use overlapping grid elements to grow/shrink textarea's height #2143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vursen
reviewed
Jun 22, 2021
|
Kudos, SonarCloud Quality Gate passed!
|
vaadin-bot
added a commit
that referenced
this pull request
Jul 23, 2021
…ght (#2143) (#2266) * refactor: use overlapping grid elements to grow/shrink textarea's height fixes: #291 * fix visual material's tests * update form-layout-item-text-area screenshot Co-authored-by: Farhad <[email protected]>
sissbruecker
added a commit
that referenced
this pull request
Sep 3, 2021
This change prevents the page from scrolling while the text area is measuring its height as part of the auto resize feature, when entering or removing text into the textarea. Cherry pick of: vaadin/vaadin-text-field#581 Rollback of changes from: #2143
sissbruecker
added a commit
that referenced
this pull request
Sep 6, 2021
This change prevents the page from scrolling while the text area is measuring its height as part of the auto resize feature, when entering or removing text into the textarea. Cherry pick of: vaadin/vaadin-text-field#581 Rollback of changes from: #2143
sissbruecker
added a commit
that referenced
this pull request
Sep 6, 2021
This change prevents the page from scrolling while the text area is measuring its height as part of the auto resize feature, when entering or removing text into the textarea. Cherry pick of: vaadin/vaadin-text-field#581 Rollback of changes from: #2143
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to: #291
The previous solution manually changes the height of the textarea which
imposes some problem with the native focus/scroll behaviour of
browsers.