Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add time-picker using slotted input #2307

Closed
wants to merge 5 commits into from
Closed

Conversation

web-padawan
Copy link
Member

@web-padawan web-padawan commented Aug 6, 2021

Description

This PR adds @vaadin/combo-box base class, Lumo and Material theme, and visual tests.

Fixes #2201

Depends on #2293

Type of change

  • Feature

@web-padawan web-padawan added the a11y Accessibility issue label Aug 6, 2021
@web-padawan web-padawan force-pushed the feat/time-picker branch 5 times, most recently from 3e03b1e to 07c069c Compare August 6, 2021 12:59
@web-padawan web-padawan force-pushed the feat/time-picker branch 2 times, most recently from 2a43262 to d663fba Compare August 16, 2021 13:50
@web-padawan
Copy link
Member Author

Closing in favor of #2541

@web-padawan web-padawan reopened this Sep 15, 2021
@sonarcloud
Copy link

sonarcloud bot commented Sep 15, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 40 Code Smells

No Coverage information No Coverage information
9.4% 9.4% Duplication

@web-padawan
Copy link
Member Author

Closing in favor of #2541.

@web-padawan web-padawan deleted the feat/time-picker branch April 29, 2022 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Accessibility issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-implement time-picker using slotted input and new mixins
1 participant