-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add combo-box using slotted input #2293
Conversation
e14b46f
to
e15a89e
Compare
0cf8f7a
to
ce598d6
Compare
8f20da4
to
9e2771f
Compare
Some observations when testing the component:
|
This and other related changes will be done as part of #2240 |
While the reason for removing the deprecated Did we agree at any moment to stop supporting Polymer Templates even with the template renderer? |
Hmm...can't drop support for |
I will restore the |
546ce19
to
6095519
Compare
c5516bc
to
b83e533
Compare
SonarCloud Quality Gate failed. 0 Bugs No Coverage information |
Closing in favor of #2496 |
Description
This PR adds
@vaadin/combo-box
base class, Lumo and Material theme, and visual tests.Fixes #2202
Breaking changes
render
methodNote
Some logic is imported from
vaadin-combo-box
package:ComboBoxDataProviderMixin
vaadin-combo-box-dropdown-wrapper
These will be updated in #2203, as well as JSDoc and missing TS typings.
Type of change