Fix user input #480
Merged
Fix user input #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomivirkki
reviewed
Jun 11, 2020
tomivirkki
approved these changes
Jun 12, 2020
tomivirkki
pushed a commit
that referenced
this pull request
Jun 12, 2020
* Add test for user input without value change * Do not set userInput if there is no change * Remove flag where it was added
tomivirkki
pushed a commit
that referenced
this pull request
Jun 12, 2020
* Add test for user input without value change * Do not set userInput if there is no change * Remove flag where it was added
tomivirkki
pushed a commit
that referenced
this pull request
Jun 12, 2020
* Add test for user input without value change * Do not set userInput if there is no change * Remove flag where it was added
This was referenced Jun 12, 2020
Merged
Merged
Merged
tomivirkki
added a commit
that referenced
this pull request
Jun 16, 2020
tomivirkki
added a commit
that referenced
this pull request
Jun 16, 2020
tomivirkki
added a commit
that referenced
this pull request
Jun 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes vaadin/vaadin-text-field-flow#273
Description:
pasteis also triggeringinputevent.In case this event is triggered when value wasn't changed (i.e. value was replaced with
paste, ormaxlengthis set andpasteis done),__userInputwill be set totruehere, but updating the value won't pass polymer dirty check, so the__userInputwill be preserved for the next programmatic value update and inputvaluewon't be updated.Important note:
It's possible to check for specifically
pasteaction (i.e. withe.inputTypeor withinonPaste), but it doesn't make sense to preserve__userInputin any case if dirty check won't be passed forvalueChangeafterwards, so general short solution is implemented in the PR.(It's easier to test and covers the
pastecases, cannot come up with other cases when value won't be changed andinputevent is triggered)