This repository has been archived by the owner on Dec 12, 2022. It is now read-only.
Update support for material theme and theme variant #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add APIs for theme variant support. These two apis are generated from by the generator, as we don't use generated code for grid, these two are moved here in this way.
ZheSun88
changed the title
vaadin-bot
reviewed
Jul 13, 2018
| @@ -109,7 +110,8 @@ | |||
| @HtmlImport("frontend://flow-component-renderer.html") | |||
| @JavaScript("frontend://gridConnector.js") | |||
| public class Grid<T> extends Component implements HasDataProvider<T>, HasStyle, | |||
| HasSize, Focusable<Grid<T>>, SortNotifier<Grid<T>, GridSortOrder<T>> { | |||
| HasSize, Focusable<Grid<T>>, SortNotifier<Grid<T>, GridSortOrder<T>>, | |||
| HasTheme { | |||
|
|
|||
| protected static class UpdateQueue implements TreeUpdate { | |||
| private List<Runnable> queue = new ArrayList<>(); | |||
There was a problem hiding this comment.
|
SonarQube analysis reported 29 issues
Watch the comments in this conversation to review them. Top 10 extra issuesNote: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:
|
denis-anisimov
commented
Jul 14, 2018
There was a problem hiding this comment.
Reviewed 2 of 3 files at r4, 1 of 1 files at r5, 2 of 2 files at r6.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @vaadin-bot)
ZheSun88
approved these changes
Jul 16, 2018
There was a problem hiding this comment.
Dismissed @vaadin-bot from a discussion.
Reviewable status:complete! all files reviewed, all discussions resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is