Skip to content
This repository has been archived by the owner on May 6, 2021. It is now read-only.

Added documentation on styling of Grid #185

Merged
merged 9 commits into from
Jul 16, 2018
Merged

Conversation

mikotin
Copy link
Contributor

@mikotin mikotin commented Jun 13, 2018

This change is Reviewable

Applies to other components also
@CLAassistant
Copy link

CLAassistant commented Jun 13, 2018

CLA assistant check
All committers have signed the CLA.

@denis-anisimov
Copy link

You should add the code snippets as a validation files ( java, css). See how it's done in other tutorials.
Otherwise the validation fails.


Reviewed 1 of 1 files at r1.
Review status: 2 unresolved discussions, 0 of 1 LGTMs obtained


documentation/components/tutorial-flow-grid.asciidoc, line 895 at r1 (raw file):

indigates

typo ?


documentation/components/tutorial-flow-grid.asciidoc, line 948 at r1 (raw file):

This does not only apply in the text-fields of the grid, but - because date-field uses the text-field internally - also
the date-fields. Now the look and feel of used component - the textfield - is always the same, whether it's directly
used or wrapped within another component.

new line


Comments from Reviewable

@denis-anisimov
Copy link

Reviewed 4 of 4 files at r2.
Review status: 1 unresolved discussion, 0 of 1 LGTMs obtained


Comments from Reviewable

@ZheSun88
Copy link
Contributor

Review status: 1 unresolved discussion, 0 of 1 LGTMs obtained


a discussion (no related file):
the build failed because grid cannot find the addThemeName method, should there be a separate PR to implement hasTheme to grid, together with a grid a demo?


Comments from Reviewable

@ZheSun88
Copy link
Contributor

ZheSun88 commented Jul 13, 2018

This will start to build after vaadin/vaadin-grid-flow#245

Copy link
Contributor

@ZheSun88 ZheSun88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 unresolved discussion, 0 of 1 LGTMs obtained


documentation/components/tutorial-flow-grid.asciidoc, line 948 at r1 (raw file):

Previously, denis-anisimov (Denis) wrote…

new line

new line added

Copy link

@denis-anisimov denis-anisimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r4.
Reviewable status: all discussions resolved, 0 of 1 LGTMs obtained, and 1 stale

ZheSun88 and others added 2 commits July 16, 2018 09:21
1.1-snapshot is for the tree-grid support, 1.2-snapshot is for the
development
Copy link

@denis-anisimov denis-anisimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r5, 1 of 1 files at r6.
Reviewable status: all discussions resolved, 0 of 1 LGTMs obtained, and 1 stale

Copy link

@denis-anisimov denis-anisimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all discussions resolved, 1 of 1 LGTMs obtained

a discussion (no related file):

Previously, ZheSun88 (Sun Zhe) wrote…

the build failed because grid cannot find the addThemeName method, should there be a separate PR to implement hasTheme to grid, together with a grid a demo?

Should be separate PR, yes.


@denis-anisimov denis-anisimov merged commit 6f371eb into master Jul 16, 2018
@denis-anisimov denis-anisimov deleted the grid-styling-doc branch July 16, 2018 08:13
ZheSun88 pushed a commit that referenced this pull request Sep 10, 2018
# Conflicts:
#	documentation/pom.xml
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants