-
Notifications
You must be signed in to change notification settings - Fork 100
Added documentation on styling of Grid #185
Conversation
Applies to other components also
You should add the code snippets as a validation files ( java, css). See how it's done in other tutorials. Reviewed 1 of 1 files at r1. documentation/components/tutorial-flow-grid.asciidoc, line 895 at r1 (raw file):
typo ? documentation/components/tutorial-flow-grid.asciidoc, line 948 at r1 (raw file):
new line Comments from Reviewable |
Reviewed 4 of 4 files at r2. Comments from Reviewable |
Review status: 1 unresolved discussion, 0 of 1 LGTMs obtained a discussion (no related file): Comments from Reviewable |
This will start to build after vaadin/vaadin-grid-flow#245 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 unresolved discussion, 0 of 1 LGTMs obtained
documentation/components/tutorial-flow-grid.asciidoc, line 948 at r1 (raw file):
Previously, denis-anisimov (Denis) wrote…
new line
new line added
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r4.
Reviewable status: all discussions resolved, 0 of 1 LGTMs obtained, and 1 stale
1.1-snapshot is for the tree-grid support, 1.2-snapshot is for the development
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r5, 1 of 1 files at r6.
Reviewable status: all discussions resolved, 0 of 1 LGTMs obtained, and 1 stale
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all discussions resolved, 1 of 1 LGTMs obtained
a discussion (no related file):
Previously, ZheSun88 (Sun Zhe) wrote…
the build failed because grid cannot find the
addThemeName
method, should there be a separate PR to implementhasTheme
to grid, together with a grid a demo?
Should be separate PR, yes.
# Conflicts: # documentation/pom.xml
This change is