Bump dependencies to stable and add RTL styles #37
Conversation
|
@diego, I have updated the screenshots, but I am not sure that it is the correct behavior in RTL with icon position switched. It looks like the value is clipped now |
|
Yeah. That's coming from the Should we revert the |
|
Looks like at least border radius is now missing from one of the elements in the middle section (between elements) in both LTR and RTL (looking at the updated screenshots). |
|
Indeed. I had to zoom-in to catch that difference. |
|
Found the issue with the borders. Because now |
|
|
| <link rel="import" href="../../vaadin-text-field/src/vaadin-text-field.html"> | ||
|
|
||
| <dom-module id="vaadin-date-time-picker-date-text-field-styless" theme-for="vaadin-date-time-picker-date-text-field"> | ||
| <template> | ||
| <style> | ||
| :host([dir="rtl"]) [part="input-field"] { |
There was a problem hiding this comment.
Wouldn't it make more sense to import <link rel="import" href="../../vaadin-date-picker/src/vaadin-date-picker-text-field.html"> and then something like:
class DateTimePickerDateTextFieldElement extends customElements.get('vaadin-date-picker-text-field')Then we wouldn't need to duplicate the RTL styles here.
There was a problem hiding this comment.
Also noticed there's a typo in -styless"
|
|
||
| :not(*):placeholder-shown, /* to prevent broken styles on IE */ | ||
| :host([dir="rtl"]) [part="value"]:placeholder-shown, | ||
| :host([dir="rtl"]) [part="input-field"] ::slotted(input:placeholder-shown) { | ||
| --_lumo-text-field-overflow-mask-image: none; | ||
| } | ||
|
|
||
| :host([dir="rtl"]) [part="value"], | ||
| :host([dir="rtl"]) [part="input-field"] ::slotted(input) { | ||
| --_lumo-text-field-overflow-mask-image: linear-gradient(to left, transparent, #000 1.25em); | ||
| } |
There was a problem hiding this comment.
I guess these can also be removed from here if this element is made to extend vaadin-date-picker-text-field?
DiegoCardoso
changed the title
No description provided.