Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[date-time-picker] Avoid duplication of RTL styles from vaadin-date-picker-text-field #828

Closed
Haprog opened this issue May 6, 2020 · 2 comments
Closed

[date-time-picker] Avoid duplication of RTL styles from vaadin-date-picker-text-field #828

Haprog opened this issue May 6, 2020 · 2 comments
Labels
enhancement New feature or request refactor Internal improvement vaadin-date-time-picker

Comments

@Haprog
Copy link
Contributor

Haprog commented May 6, 2020

This PR duplicated some styles from vaadin-date-picker-text-field. We should refactor this to inherit the styles instead of duplicating (maintenance problem).

Suggested solution in vaadin/vaadin-date-time-picker#37 (review) (to make vaadin-date-time-picker-date-text-field extend vaadin-date-picker-text-field).
@vaadin-bot vaadin-bot transferred this issue from vaadin/vaadin-date-time-picker May 19, 2021
@vaadin-bot vaadin-bot added enhancement New feature or request next Future ideas refactor Internal improvement vaadin-date-time-picker labels May 19, 2021
@web-padawan web-padawan changed the title Avoid duplication of RTL styles from vaadin-date-picker-text-field [date-time-picker] Avoid duplication of RTL styles from vaadin-date-picker-text-field May 28, 2021
@web-padawan web-padawan removed the next Future ideas label May 28, 2021
@web-padawan
Copy link
Member

When looking at vaadin/vaadin-date-time-picker#37 I don't see it picked to latest 1.x version 🤔

@web-padawan
Copy link
Member

In Vaadin 22 there is no duplication anymore. The PR mentioned above was re-applied in #2574. Closing as fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request refactor Internal improvement vaadin-date-time-picker
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Haprog @web-padawan @vaadin-bot