Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert changes made for resolving start-stop issue #9915

Merged
merged 1 commit into from
Jan 29, 2021

Conversation

taefi
Copy link
Contributor

@taefi taefi commented Jan 28, 2021

changes in #9553 is solved the problem of start-stop:
vaadin/spring#691, but resulted
in occasional failures with ServiceException /
TaskRejectedException: #9785.

Fixes: #9785

@taefi taefi requested a review from denis-anisimov January 28, 2021 23:07
@vaadin-bot
Copy link
Collaborator

SonarQube analysis reported 7 issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. MAJOR DevModeHandler.java#L592: Remove this unused private "checkPort" method. rule
  2. MAJOR DevModeHandler.java#L729: Either re-interrupt this method or rethrow the "InterruptedException". rule
  3. MAJOR DevModeInitializer.java#L212: Remove this unused private "isVaadinServletSubClass" method. rule
  4. MAJOR DevModeInitializer.java#L515: Refactor this method to reduce its Cognitive Complexity from 16 to the 15 allowed. rule
  5. INFO DevModeInitializer.java#L244: Do not forget to remove this deprecated code someday. rule
  6. INFO DevModeInitializer.java#L320: Complete the task associated to this TODO comment. rule
  7. INFO DevModeInitializer.java#L420: Do not forget to remove this deprecated code someday. rule

@denis-anisimov denis-anisimov merged commit fced0b9 into master Jan 29, 2021
@denis-anisimov denis-anisimov deleted the revert-flow-pull-9553 branch January 29, 2021 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

occasional mvn spring-boot:run failures with ServiceException / TaskRejectedException
3 participants