-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
occasional mvn spring-boot:run
failures with ServiceException / TaskRejectedException
#9785
Comments
@vlukashov Thanks for creating the issue. |
All the details we currently have are in the linked Slack thread. Unfortunately, there are no clear steps to reproduce the issue at the moment, but it has appeared for several people more than once. |
The exception originates in https://github.com/vaadin/flow/blob/master/flow-server/src/main/java/com/vaadin/flow/server/DevModeHandler.java#L261 and I guess it originates from the Spring Boot application being shut down during startup. The log seems to at least most of the time contain something like
|
The question is : is it the expected behavior of Spring/web app or not?
The expected behavior based on this line : Spring is shutting down. So :
So (hopefully) the exception is not the cause of this behavior. The reason might be the stop of the application during its startup and this is should be investigated. |
After the message, the app is started again but webpack dev server is never started again. |
OK, so this is "expected" behavior. |
Apparently something happens (guesses are that IDE recompilation or something else, touching something in So to reproduce this one can try getting a v19 SB app from SVC and then
If this only occurs with VSCode users then it would be low impact indeed, but as until we've figured that out, this as this is happening with the default stack should be considered high impact instead. And as there is a workaround (clean/restart), it is not a blocker but I don't see how it would be only minor either. |
I can reproduce it like this:
When
After this, when you open localhost:8080 you will see the standard "The frontend development build has not yet finished. Please wait..." until "npm install" has finished. After that, the exception is shown If you run it multiple times, be sure to delete Note1: It is not the webpack dev server process that is interrupted, it is |
The plan is to revert the fix for vaadin/spring#691 on the /flow side as it is not deemed nearly as high impact/severity issue as this one. That should fix this issue but needs to be validated (before revert merge). Then we reopen the other issue and come back to it to fix it in another way that does not cause this to reappear. |
To me it looks like only a logic problem in
If The problem is that it is marked as a permanent error instead of just not running webpack, and when asked to start webpack again it would try again. |
No it's not. The problem is in Spring. This service is the only problem here. Spring dev tools introduced unexpected problem : now every task may be simply cancelled: BOTH tasks (npm install or dev mode start taksk) Spring dev tools completely destroy all beans and recreates them. All these things are caused by Spring and dev tools. It is not possible to fix this simply. The proper fix requires serious changes in Spring add-on and most likely here. To avoid any unexpected Spring behavior the easiest way to revert the fix for |
Occasionally starting a Vaadin project in the dev mode fails with a stack trace like below. The exception is typically gone after restating the app (
mvn spring-boot:run
) or clearing the project (mvn clean
).more context: https://vaadin.slack.com/archives/CDNTYMS9H/p1608663499135200
The text was updated successfully, but these errors were encountered: