Unify system error messages #4542
Conversation
There was a problem hiding this comment.
Reviewable status: 1 unresolved discussion, 0 of 1 LGTMs obtained
flow-client/src/main/java/com/vaadin/client/SystemErrorHandler.java, line 116 at r1 (raw file):
*/ public void handleError(String errorMessage) { Console.error(errorMessage);
This is now logged twice: once here and again when calling the new handleError(caption, message, details).
You can move this line inside the if-block below to still log it in production mode.
There was a problem hiding this comment.
Reviewable status: all discussions resolved, 0 of 1 LGTMs obtained
flow-client/src/main/java/com/vaadin/client/SystemErrorHandler.java, line 116 at r1 (raw file):
Previously, pekam (Pekka Maanpää) wrote…
This is now logged twice: once here and again when calling the new
handleError(caption, message, details).You can move this line inside the
if-block below to still log it in production mode.
done
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status: all discussions resolved, 0 of 1 LGTMs obtained, and 1 stale
There was a problem hiding this comment.
Reviewed 1 of 1 files at r3.
Reviewable status: all discussions resolved, 0 of 1 LGTMs obtained, and 1 stale
* Unify system error messages Fixes #3777 * Remove duplicate logging call * Fix a test by finding only direct children of body with class 'message'
* Unify system error messages Fixes #3777 * Remove duplicate logging call * Fix a test by finding only direct children of body with class 'message'
Fixes #3777
This change is