Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some system-error are not wrapped in a div class=message #3777

Closed
manolo opened this issue Mar 28, 2018 · 0 comments
Closed

Some system-error are not wrapped in a div class=message #3777

manolo opened this issue Mar 28, 2018 · 0 comments
Assignees
@denis-anisimov
Labels
bug theming
Milestone
1.0.5

Comments

@manolo
Copy link
Member

manolo commented Mar 28, 2018

Align all system errors so as they always have a div class=caption and a div class=message that makes easy to style by the app.

In this screenshot, you can see two messages with different layout. The second one is difficult to style.

screen shot 2018-03-27 at 11 36 41
@manolo manolo changed the title Some system-error are wrapped in a div class=message Some system-error are not wrapped in a div class=message Mar 28, 2018
@pleku pleku added this to the 1.0 Maintenance milestone Apr 18, 2018
@denis-anisimov denis-anisimov self-assigned this Aug 18, 2018
denis-anisimov pushed a commit that referenced this issue Aug 18, 2018
Unify system error messages
4a3eabf 
Fixes #3777
@denis-anisimov denis-anisimov mentioned this issue Aug 18, 2018
Merged
pekam pushed a commit that referenced this issue Aug 21, 2018
@pekam
Unify system error messages (#4542)
db73c7b 
* Unify system error messages

Fixes #3777

* Remove duplicate logging call

* Fix a test by finding only direct children of body with class 'message'
pekam pushed a commit that referenced this issue Aug 21, 2018
@pekam
Unify system error messages (#4542)
800446b 
* Unify system error messages

Fixes #3777

* Remove duplicate logging call

* Fix a test by finding only direct children of body with class 'message'
@pekam pekam mentioned this issue Aug 21, 2018
Merged
pekam pushed a commit that referenced this issue Aug 21, 2018
@pekam
Unify system error messages (#4542)
d580213 
* Unify system error messages

Fixes #3777

* Remove duplicate logging call

* Fix a test by finding only direct children of body with class 'message'
@pekam pekam modified the milestones: 1.0 Maintenance, 1.0.5 Aug 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@denis-anisimov denis-anisimov

Labels
bug theming
Projects
None yet
Milestone
1.0.5
Development

No branches or pull requests
4 participants
@manolo @pleku @denis-anisimov @pekam