Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use FaviconHandler only for servlets #4495

Merged
merged 1 commit into from
Aug 9, 2018
Merged

Use FaviconHandler only for servlets #4495

merged 1 commit into from
Aug 9, 2018

Conversation

Legioth
Copy link
Member

@Legioth Legioth commented Aug 8, 2018 •
edited by SomeoneToIgnore
Loading

Fixes #4426

This change is Reviewable

@vaadin-bot
Copy link
Collaborator

SonarQube analysis reported 6 issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. CRITICAL VaadinService.java#L2053: First sentence of Javadoc is incomplete (period is missing) or not present. rule
  2. CRITICAL VaadinService.java#L2087: First sentence of Javadoc is incomplete (period is missing) or not present. rule
  3. CRITICAL VaadinService.java#L2099: First sentence of Javadoc is incomplete (period is missing) or not present. rule
  4. CRITICAL VaadinService.java#L2111: First sentence of Javadoc is incomplete (period is missing) or not present. rule
  5. MINOR VaadinService.java#L527: This call to "add()" may be a performance hot spot if the collection is large. rule
  6. MINOR VaadinService.java#L528: This call to "remove()" may be a performance hot spot if the collection is large. rule

denis-anisimov
denis-anisimov approved these changes Aug 9, 2018
View reviewed changes
Copy link
Contributor

@denis-anisimov denis-anisimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1.
Reviewable status: all discussions resolved, 0 of 1 LGTMs obtained

denis-anisimov
denis-anisimov approved these changes Aug 9, 2018
View reviewed changes
Copy link
Contributor

@denis-anisimov denis-anisimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: all discussions resolved, 0 of 1 LGTMs obtained, and 1 stale

@denis-anisimov denis-anisimov added this to the 1.1 milestone Aug 9, 2018
@denis-anisimov denis-anisimov merged commit 996594c into master Aug 9, 2018
@denis-anisimov denis-anisimov deleted the faviconForOnlyServlet branch August 9, 2018 07:33
denis-anisimov pushed a commit that referenced this pull request Aug 9, 2018
@Legioth
Use FaviconHandler only for servlets (#4495)
3bc9346 
Fixes #4426
# Conflicts:
#	flow-server/src/main/java/com/vaadin/flow/server/VaadinServletService.java
denis-anisimov pushed a commit that referenced this pull request Aug 10, 2018
Use FaviconHandler only for servlets (#4495) (#4501)
a32f77c 
Fixes #4426
@ZheSun88 ZheSun88 modified the milestones: 1.1, 1.1.0.beta2 Aug 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denis-anisimov denis-anisimov denis-anisimov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1.0.beta2
Development

Successfully merging this pull request may close these issues.
4 participants
@Legioth @vaadin-bot @denis-anisimov @ZheSun88