Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FaviconHandler assumes VaadinServletRequest without a check #4426

Closed
domdorn opened this issue Jul 21, 2018 · 0 comments
Closed

FaviconHandler assumes VaadinServletRequest without a check #4426

domdorn opened this issue Jul 21, 2018 · 0 comments
Labels
bug

Comments

@domdorn
Copy link

domdorn commented Jul 21, 2018

I'm in the process of making Vaadin run on non-servlet based servers ( Play!Framework / Akka-HTTP )

At the moment, the com.vaadin.flow.server.communication.FaviconHandler assumes that the incoming VaadinRequest is a VaadinServletRequest without checking and just casting it.. this results in a ClassCastException if the request is not a ServletRequest.

for the moment, I just implemented my own
createRequestHandlers in the VaadinService which does not load this particular handler. A corresponding check would be nice.
Legioth added a commit that referenced this issue Aug 8, 2018
@Legioth
Use FaviconHandler only for servlets
50f61da 
Fixes #4426
@Legioth Legioth mentioned this issue Aug 8, 2018
Merged
denis-anisimov pushed a commit that referenced this issue Aug 9, 2018
@Legioth
Use FaviconHandler only for servlets (#4495)
996594c 
Fixes #4426
denis-anisimov pushed a commit that referenced this issue Aug 9, 2018
@Legioth
Use FaviconHandler only for servlets (#4495)
3bc9346 
Fixes #4426
# Conflicts:
#	flow-server/src/main/java/com/vaadin/flow/server/VaadinServletService.java
@denis-anisimov denis-anisimov mentioned this issue Aug 9, 2018
Merged
denis-anisimov pushed a commit that referenced this issue Aug 10, 2018
Use FaviconHandler only for servlets (#4495) (#4501)
a32f77c 
Fixes #4426
@denis-anisimov denis-anisimov added this to the 1.0 Maintenance milestone Aug 14, 2018
This was referenced Sep 22, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@domdorn @denis-anisimov @pekam