Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use InitialPropertiesHandler for injected elements (#4454) #4457

Merged
merged 1 commit into from
Jul 31, 2018
Merged

Use InitialPropertiesHandler for injected elements (#4454) #4457

merged 1 commit into from
Jul 31, 2018

Conversation

denis-anisimov
Copy link
Contributor

@denis-anisimov denis-anisimov commented Jul 31, 2018 •
edited by SomeoneToIgnore
Loading

Fixes #4304

This change is Reviewable

@vaadin-bot
Copy link
Collaborator

SonarQube analysis reported 5 issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. MAJOR SimpleElementBindingStrategy.java#L195: Make the enclosing method "static" or remove this set. rule
  2. MAJOR SimpleElementBindingStrategy.java#L1005: Remove this unused private "invokeWhenNodeIsConstructed" method. rule
  3. MAJOR SimpleElementBindingStrategy.java#L1312: Equality tests should not be made with floating point values. rule
  4. INFO SimpleElementBindingStrategy.java#L195: Write to static field com.vaadin.client.flow.binding.SimpleElementBindingStrategy.boundNodes from instance method com.vaadin.client.flow.binding.SimpleElementBindingStrategy.bind(StateNode, Element, BinderContext) rule
  5. INFO SimpleElementBindingStrategy.java#L416: Complete the task associated to this TODO comment. rule

gilberto-torrezan
gilberto-torrezan approved these changes Jul 31, 2018
View reviewed changes
Copy link
Contributor

@gilberto-torrezan gilberto-torrezan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1.
Reviewable status: all discussions resolved, 0 of 1 LGTMs obtained, and 1 stale

@gilberto-torrezan gilberto-torrezan added this to the 1.0.4 milestone Jul 31, 2018
@gilberto-torrezan gilberto-torrezan merged commit f32a7b9 into 1.0 Jul 31, 2018
@gilberto-torrezan gilberto-torrezan deleted the 4304-injected-initial-properties branch July 31, 2018 11:40
This was referenced Oct 4, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gilberto-torrezan gilberto-torrezan gilberto-torrezan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.4
Development

Successfully merging this pull request may close these issues.
3 participants
@denis-anisimov @vaadin-bot @gilberto-torrezan