Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use InitialPropertiesHandler for injected elements #4454

Merged
merged 2 commits into from
Jul 31, 2018

Conversation

denis-anisimov
Copy link
Contributor

@denis-anisimov denis-anisimov commented Jul 31, 2018

Fixes #4304


This change is Reviewable

Copy link
Contributor

@gilberto-torrezan gilberto-torrezan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1.
Reviewable status: 2 unresolved discussions, 0 of 1 LGTMs obtained

a discussion (no related file):
Maybe this bugfix will also fix vaadin/vaadin-grid-flow#71



flow-tests/test-root-context/src/main/java/com/vaadin/flow/uitest/ui/KeyPressListenerView.java, line 39 at r1 (raw file):

        field.addKeyPressListener(Key.ENTER, event -> {
            div.setText("enter");
            ;

Extra ; here. In fact for this lambda you can even remove the curly bracers.


flow-tests/test-root-context/src/main/java/com/vaadin/flow/uitest/ui/KeyPressListenerView.java, line 42 at r1 (raw file):

        });
        field.addKeyPressListener(Key.ARROW_DOWN, event -> {
            System.out.println("arrow-down");

Shouldn't it be div.setText("arrow-down") instead?

@denis-anisimov denis-anisimov force-pushed the 4304-injected-elements-initial-properties branch from 47cf118 to b7cae0e Compare July 31, 2018 07:20
Copy link
Contributor Author

@denis-anisimov denis-anisimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 2 unresolved discussions, 0 of 1 LGTMs obtained


flow-tests/test-root-context/src/main/java/com/vaadin/flow/uitest/ui/KeyPressListenerView.java, line 39 at r1 (raw file):

Previously, gilberto-torrezan (Gilberto Torrezan) wrote…

Extra ; here. In fact for this lambda you can even remove the curly bracers.

This is leftover from unrelated investigation.

Removed.


flow-tests/test-root-context/src/main/java/com/vaadin/flow/uitest/ui/KeyPressListenerView.java, line 42 at r1 (raw file):

Previously, gilberto-torrezan (Gilberto Torrezan) wrote…

Shouldn't it be div.setText("arrow-down") instead?

This is leftover from unrelated investigation.

Copy link
Contributor

@gilberto-torrezan gilberto-torrezan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2.
Reviewable status: all discussions resolved, 0 of 1 LGTMs obtained, and 1 stale

Copy link
Contributor

@gilberto-torrezan gilberto-torrezan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all discussions resolved, 1 of 1 LGTMs obtained

@vaadin-bot
Copy link
Collaborator

SonarQube analysis reported 5 issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. MAJOR SimpleElementBindingStrategy.java#L195: Make the enclosing method "static" or remove this set. rule
  2. MAJOR SimpleElementBindingStrategy.java#L1005: Remove this unused private "invokeWhenNodeIsConstructed" method. rule
  3. MAJOR SimpleElementBindingStrategy.java#L1312: Equality tests should not be made with floating point values. rule
  4. INFO SimpleElementBindingStrategy.java#L195: Write to static field com.vaadin.client.flow.binding.SimpleElementBindingStrategy.boundNodes from instance method com.vaadin.client.flow.binding.SimpleElementBindingStrategy.bind(StateNode, Element, BinderContext) rule
  5. INFO SimpleElementBindingStrategy.java#L416: Complete the task associated to this TODO comment. rule

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants