fix: prevent Optional capture in serializable predicate #20360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Optional is not serializable, so capturing it into a SerializablePredicate will prevent serialization to succeed.
|
tepi
previously approved these changes
Oct 29, 2024
|
@tepi @mshabarov do you think we should also address #20361 in this PR? |
|
@mcollovati yes, let's address here all these reported issues with Optional, if possible. |
mcollovati
dismissed
tepi’s stale review
Should be reviewed again after changes for #20361
|
#20361 has been closed because the real culprit of the serialization issue was in |
tepi
approved these changes
Oct 29, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
Oct 29, 2024
Optional is not serializable, so capturing it into a SerializablePredicate will prevent serialization to succeed.
vaadin-bot
pushed a commit
that referenced
this pull request
Oct 29, 2024
Optional is not serializable, so capturing it into a SerializablePredicate will prevent serialization to succeed.
vaadin-bot
pushed a commit
that referenced
this pull request
Oct 29, 2024
Optional is not serializable, so capturing it into a SerializablePredicate will prevent serialization to succeed.
vaadin-bot
pushed a commit
that referenced
this pull request
Oct 29, 2024
Optional is not serializable, so capturing it into a SerializablePredicate will prevent serialization to succeed.
vaadin-bot
added a commit
that referenced
this pull request
Oct 29, 2024
) Optional is not serializable, so capturing it into a SerializablePredicate will prevent serialization to succeed. Co-authored-by: Marco Collovati <[email protected]>
vaadin-bot
added a commit
that referenced
this pull request
Oct 29, 2024
) Optional is not serializable, so capturing it into a SerializablePredicate will prevent serialization to succeed. Co-authored-by: Marco Collovati <[email protected]>
vaadin-bot
added a commit
that referenced
this pull request
Oct 29, 2024
) Optional is not serializable, so capturing it into a SerializablePredicate will prevent serialization to succeed. Co-authored-by: Marco Collovati <[email protected]>
vaadin-bot
added a commit
that referenced
this pull request
Oct 29, 2024
) Optional is not serializable, so capturing it into a SerializablePredicate will prevent serialization to succeed. Co-authored-by: Marco Collovati <[email protected]>
|
This ticket/PR has been released with Vaadin 24.6.0.alpha2 and is also targeting the upcoming stable 24.6.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optional is not serializable, so capturing it into a SerializablePredicate will prevent serialization to succeed.