fix: prevent Optional capture in serializable predicate (#20360) (#20369

) Optional is not serializable, so capturing it into a SerializablePredicate will prevent serialization to succeed. Co-authored-by: Marco Collovati <[email protected]>
vaadin · Oct 29, 2024 · 1251521 · 1251521
1 parent 4c09983
commit 1251521
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 13 deletions.
diff --git a/flow-data/src/main/java/com/vaadin/flow/data/provider/AbstractListDataView.java b/flow-data/src/main/java/com/vaadin/flow/data/provider/AbstractListDataView.java
@@ -113,11 +113,10 @@ public Optional<T> getPreviousItem(T item) {
     @Override
     public AbstractListDataView<T> addFilter(SerializablePredicate<T> filter) {
         Objects.requireNonNull(filter, "Filter to add cannot be null");
-        Optional<SerializablePredicate<T>> originalFilter = DataViewUtils
-                .getComponentFilter(component);
-        SerializablePredicate<T> newFilter = originalFilter.isPresent()
-                ? item -> originalFilter.get().test(item) && filter.test(item)
-                : filter;
+        SerializablePredicate<T> newFilter = DataViewUtils
+                .<T> getComponentFilter(component)
+                .map(originalFilter -> originalFilter.and(filter))
+                .orElse(filter);
         return setFilter(newFilter);
     }
 

diff --git a/flow-data/src/test/java/com/vaadin/flow/data/provider/AbstractListDataViewTest.java b/flow-data/src/test/java/com/vaadin/flow/data/provider/AbstractListDataViewTest.java
@@ -27,23 +27,26 @@
 import java.util.stream.Collectors;
 import java.util.stream.Stream;
 
+import org.junit.Assert;
+import org.junit.Before;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.rules.ExpectedException;
+import org.mockito.Mockito;
+
+import com.vaadin.flow.component.Component;
 import com.vaadin.flow.component.ComponentEventListener;
 import com.vaadin.flow.component.Tag;
 import com.vaadin.flow.function.SerializableBiConsumer;
 import com.vaadin.flow.function.SerializableComparator;
 import com.vaadin.flow.function.SerializablePredicate;
+import com.vaadin.flow.function.SerializableSupplier;
 import com.vaadin.flow.function.ValueProvider;
 import com.vaadin.flow.shared.Registration;
 import com.vaadin.flow.tests.data.bean.Item;
-import org.junit.Assert;
-import org.junit.Before;
-import org.junit.Rule;
-import org.junit.Test;
-import org.junit.rules.ExpectedException;
 
-import com.vaadin.flow.component.Component;
-import com.vaadin.flow.function.SerializableSupplier;
-import org.mockito.Mockito;
+import static com.vaadin.flow.tests.server.ClassesSerializableUtils.serializeAndDeserialize;
+import static org.junit.Assert.assertNotNull;
 
 public class AbstractListDataViewTest {
 
@@ -1237,6 +1240,18 @@ public void filterOrSortingChangedCallback_emptyCallbackProvided_throws() {
         new ListDataViewImpl(() -> dataProvider, component, null);
     }
 
+    @Test
+    public void addFilter_serialize_dataViewSerializable() throws Throwable {
+        DataViewUtils.setComponentFilter(component, term -> true);
+        ListDataProvider<String> dp = DataProvider.ofCollection(Set.of("A"));
+        ListDataViewImpl listDataView = new ListDataViewImpl(() -> dp,
+                component, (filter, sort) -> {
+                });
+        listDataView.addFilter(term -> true);
+        ListDataViewImpl out = serializeAndDeserialize(listDataView);
+        assertNotNull(out);
+    }
+
     private static class ListDataViewImpl extends AbstractListDataView<String> {
 
         public ListDataViewImpl(