Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: import parent theme lumoImports in dev bundle mode #20325

Merged
merged 4 commits into from
Oct 29, 2024
Merged

fix: import parent theme lumoImports in dev bundle mode #20325

merged 4 commits into from
Oct 29, 2024

Commits on Oct 24, 2024

  1. fix: import parent theme lumoImports in dev bundle mode 

    Adds missing css imports for parent theme when given in parent theme.json with lumoImports property and running with dev bundle.

Fixes: #19567
    @tltv
    tltv committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    7c05d67 View commit details
    Browse the repository at this point in the history

  2. test: fix test

    @tltv
    tltv committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    068c06c View commit details
    Browse the repository at this point in the history

  3. test: fix test

    @tltv
    tltv committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    7227f5c View commit details
    Browse the repository at this point in the history

  4. chore: catch IllegalArgumentException in CssBundler 

    Catch and debug log IllegalArgumentException possibly thrown from potentialFile.toPath() in Windows. Url's in css like 'https://fonts.googleapis.com/css?family=Itim' shouldn't be considered as copyable asset files.
    @tltv
    tltv committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    cba2a35 View commit details
    Browse the repository at this point in the history