fix: import parent theme lumoImports in dev bundle mode #20325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds missing css imports for parent theme when given in parent theme.json with lumoImports property and running with dev bundle. Fixes: #19567
Catch and debug log IllegalArgumentException possibly thrown from potentialFile.toPath() in Windows. Url's in css like 'https://fonts.googleapis.com/css?family=Itim' shouldn't be considered as copyable asset files.
tltv
force-pushed
the
fix/19567-import-globals-for-parent-theme
branch
from
d3366a0
to
cba2a35
Compare
|
mshabarov
approved these changes
Oct 29, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
Oct 29, 2024
* fix: import parent theme lumoImports in dev bundle mode Adds missing css imports for parent theme when given in parent theme.json with lumoImports property and running with dev bundle. Fixes: #19567 * test: fix test * test: fix test * chore: catch IllegalArgumentException in CssBundler Catch and debug log IllegalArgumentException possibly thrown from potentialFile.toPath() in Windows. Url's in css like 'https://fonts.googleapis.com/css?family=Itim' shouldn't be considered as copyable asset files.
|
Hi @tltv and @mshabarov, when i performed cherry-pick to this commit to 24.3, i have encountered the following issue. Can you take a look and pick it manually? |
vaadin-bot
pushed a commit
that referenced
this pull request
Oct 29, 2024
* fix: import parent theme lumoImports in dev bundle mode Adds missing css imports for parent theme when given in parent theme.json with lumoImports property and running with dev bundle. Fixes: #19567 * test: fix test * test: fix test * chore: catch IllegalArgumentException in CssBundler Catch and debug log IllegalArgumentException possibly thrown from potentialFile.toPath() in Windows. Url's in css like 'https://fonts.googleapis.com/css?family=Itim' shouldn't be considered as copyable asset files.
vaadin-bot
added a commit
that referenced
this pull request
Oct 29, 2024
) * fix: import parent theme lumoImports in dev bundle mode Adds missing css imports for parent theme when given in parent theme.json with lumoImports property and running with dev bundle. Fixes: #19567 * test: fix test * test: fix test * chore: catch IllegalArgumentException in CssBundler Catch and debug log IllegalArgumentException possibly thrown from potentialFile.toPath() in Windows. Url's in css like 'https://fonts.googleapis.com/css?family=Itim' shouldn't be considered as copyable asset files. Co-authored-by: Tomi Virtanen <[email protected]>
mshabarov
pushed a commit
that referenced
this pull request
Oct 30, 2024
) * fix: import parent theme lumoImports in dev bundle mode Adds missing css imports for parent theme when given in parent theme.json with lumoImports property and running with dev bundle. Fixes: #19567 * test: fix test * test: fix test * chore: catch IllegalArgumentException in CssBundler Catch and debug log IllegalArgumentException possibly thrown from potentialFile.toPath() in Windows. Url's in css like 'https://fonts.googleapis.com/css?family=Itim' shouldn't be considered as copyable asset files. Co-authored-by: Tomi Virtanen <[email protected]>
|
This ticket/PR has been released with Vaadin 24.4.15. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds missing css imports for parent theme when given in parent theme.json with lumoImports property and running with dev bundle.
Fixes: #19567