feat: Update navigation method signatures #17407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makes UI#navigate, BeforeEvent#rerouteTo and BeforeEvent#forwardTo methods more consistent without changing the existing API: - adds new methods in BeforeEvent that accepts route parameters. - adds new methods in BeforeEvent that accepts query parameters. - improves forwardTo and rerouteTo to accept route parameters being part of the location String (same way as UI#navigate does it already). Fixes: #14553
Sonatype Lift is retiringSonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console. |
mcollovati
reviewed
Aug 10, 2023
mcollovati
approved these changes
Aug 10, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
mshabarov
approved these changes
Aug 10, 2023
|
This ticket/PR has been released with Vaadin 24.2.0.alpha7 and is also targeting the upcoming stable 24.2.0 version. |
This was referenced Sep 5, 2023
vaadin-bot
pushed a commit
that referenced
this pull request
Sep 22, 2023
* feat: Update navigation method signatures This change makes UI#navigate, BeforeEvent#rerouteTo and BeforeEvent#forwardTo methods more consistent without changing the existing API: - adds new methods in BeforeEvent that accepts route parameters. - adds new methods in BeforeEvent that accepts query parameters. - improves forwardTo and rerouteTo to accept route parameters being part of the location String (same way as UI#navigate does it already). Fixes: #14553 * Fixed javadoc * Added hasRedirectQueryParameters()
vaadin-bot
pushed a commit
that referenced
this pull request
Sep 22, 2023
* feat: Update navigation method signatures This change makes UI#navigate, BeforeEvent#rerouteTo and BeforeEvent#forwardTo methods more consistent without changing the existing API: - adds new methods in BeforeEvent that accepts route parameters. - adds new methods in BeforeEvent that accepts query parameters. - improves forwardTo and rerouteTo to accept route parameters being part of the location String (same way as UI#navigate does it already). Fixes: #14553 * Fixed javadoc * Added hasRedirectQueryParameters()
vaadin-bot
added a commit
that referenced
this pull request
Sep 22, 2023
* feat: Update navigation method signatures This change makes UI#navigate, BeforeEvent#rerouteTo and BeforeEvent#forwardTo methods more consistent without changing the existing API: - adds new methods in BeforeEvent that accepts route parameters. - adds new methods in BeforeEvent that accepts query parameters. - improves forwardTo and rerouteTo to accept route parameters being part of the location String (same way as UI#navigate does it already). Fixes: #14553 * Fixed javadoc * Added hasRedirectQueryParameters() Co-authored-by: Tomi Virtanen <[email protected]>
mcollovati
pushed a commit
that referenced
this pull request
Sep 22, 2023
This change makes UI#navigate, BeforeEvent#rerouteTo and BeforeEvent#forwardTo methods more consistent without changing the existing API: - adds new methods in BeforeEvent that accepts route parameters. - adds new methods in BeforeEvent that accepts query parameters. - improves forwardTo and rerouteTo to accept route parameters being part of the location String (same way as UI#navigate does it already). Fixes: #14553
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes UI#navigate, BeforeEvent#rerouteTo and BeforeEvent#forwardTo methods more consistent without changing the existing API:
Fixes: #14553