Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make BeforeEvent forward/reroute methods consistent with UI.navigate() #8873

Closed
epricer opened this issue Aug 20, 2020 · 2 comments
Closed

Make BeforeEvent forward/reroute methods consistent with UI.navigate() #8873

epricer opened this issue Aug 20, 2020 · 2 comments
Labels
enhancement Help wanted routing

Comments

@epricer
Copy link

epricer commented Aug 20, 2020

It would be nice to have BeforeEvent.forwardTo() and BeforeEvent.rerouteTo() methods that have the same signature as the UI.navigate() method that takes a class an a single route parameter.

The existing UI.navigate() method is very convenient, and calling the BeforeEvent methods requires more boilerplate code.
@pleku
Copy link
Contributor

pleku commented Aug 24, 2020

Sounds like a reasonable request. Would be up for grabs for contributing. Unit tests mandatory to RouterTest, ITs to RerouteIT & ForwardToIT would be surplus.

@mshabarov
Copy link
Contributor

Have been already done via #17407. Proposed for closure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Help wanted routing
Projects
Vaadin Flow enhancements backlog (Vaadin 10+)
Status: Done / Pending Release
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pleku @epricer @mshabarov