Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make IPhone version above 14.7 browsers allowed for Vaadin (#11821) (CP: 8.0) #11835

Merged
merged 1 commit into from
Sep 14, 2021
Merged

fix: make IPhone version above 14.7 browsers allowed for Vaadin (#11821) (CP: 8.0) #11835

merged 1 commit into from
Sep 14, 2021

Conversation

vaadin-bot
Copy link
Collaborator

No description provided.

@vaadin-bot
Copy link
Collaborator Author

SonarQube analysis reported 2 issues

  1. MAJOR BrowserDetails.java#L600: Refactor this method to reduce its Cognitive Complexity from 16 to the 15 allowed. rule
  2. MINOR BrowserDetails.java#L614: Replace this if-then-else statement by a single return statement. rule

@vaadin-bot
Copy link
Collaborator Author

This PR is eligible for auto-merging policy, so it has been approved automatically.[Message is sent from bot]

@vaadin-bot vaadin-bot merged commit f4b8ff4 into 8.0 Sep 14, 2021
@vaadin-bot vaadin-bot deleted the cherry-pick-11821-to-8.0-1631606556306 branch September 14, 2021 09:02
@vaadin-bot
Copy link
Collaborator Author

This PR has been merged with 'squash' method.[Message is sent from bot]

@vaadin-bot
Copy link
Collaborator Author

This ticket/PR has been released with platform 21.0.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaadin-review-bot vaadin-review-bot vaadin-review-bot approved these changes

Assignees
No one assigned
Labels
Released with Platform 21.0.2 +0.0.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vaadin-bot @vaadin-review-bot