Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make IPhone version above 14.7 browsers allowed for Vaadin #11821

Merged
merged 4 commits into from
Sep 14, 2021
Merged

fix: make IPhone version above 14.7 browsers allowed for Vaadin #11821

merged 4 commits into from
Sep 14, 2021

Conversation

denis-anisimov
Copy link
Contributor

@denis-anisimov denis-anisimov commented Sep 13, 2021 •
edited
Loading

Fixes #11654

Description

Please list all relevant dependencies in this section and provide summary of the change, motivation and context.

Fixes # (issue)

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

@mshabarov mshabarov self-requested a review September 13, 2021 11:14
sonatype-lift[bot]
sonatype-lift bot reviewed Sep 13, 2021
View reviewed changes
flow-server/src/main/java/com/vaadin/flow/shared/BrowserDetails.java Outdated
@@ -56,6 +56,8 @@
private boolean isIPhone;
private boolean isChromeOS;

private boolean isIPhone14_7OrHigher;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UnusedVariable: The field 'isIPhone14_7OrHigher' is never read.
(at-me in a reply with help or ignore)

caalador
caalador reviewed Sep 14, 2021
View reviewed changes
Copy link
Contributor

@caalador caalador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be more explicit on the app that the test string is for.

flow-server/src/test/java/com/vaadin/flow/shared/BrowserDetailsTest.java Outdated Show resolved Hide resolved
flow-server/src/test/java/com/vaadin/flow/shared/BrowserDetailsTest.java Outdated Show resolved Hide resolved
caalador
caalador previously approved these changes Sep 14, 2021
View reviewed changes
Copy link
Contributor

@caalador caalador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably needs merge from master to get the error pattern fixed for the failing test.

@denis-anisimov
Copy link
Contributor Author

Probably needs merge from master to get the error pattern fixed for the failing test.

right...

@vaadin-bot
Copy link
Collaborator

SonarQube analysis reported 2 issues

  1. MAJOR BrowserDetails.java#L600: Refactor this method to reduce its Cognitive Complexity from 16 to the 15 allowed. rule
  2. MINOR BrowserDetails.java#L614: Replace this if-then-else statement by a single return statement. rule

@caalador caalador merged commit a561e5e into master Sep 14, 2021
@caalador caalador deleted the 11654-safari-too-old branch September 14, 2021 07:45
vaadin-bot pushed a commit that referenced this pull request Sep 14, 2021
@vaadin-bot
fix: make IPhone version above 14.7 browsers allowed for Vaadin (#11821)
d74f1c6 
Fixes #11654
@vaadin-bot
Copy link
Collaborator

Hi @denis-anisimov and @caalador, when i performed cherry-pick to this commit to 2.7, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick a561e5e
error: could not apply a561e5e... fix: make IPhone version above 14.7 browsers allowed for Vaadin (#11821)
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add ' or 'git rm '
hint: and commit the result with 'git commit'

vaadin-bot pushed a commit that referenced this pull request Sep 14, 2021
@vaadin-bot
fix: make IPhone version above 14.7 browsers allowed for Vaadin (#11821)
1b2225a 
Fixes #11654
@vaadin-bot
Copy link
Collaborator

Hi @denis-anisimov and @caalador, when i performed cherry-pick to this commit to 2.6, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick a561e5e
error: could not apply a561e5e... fix: make IPhone version above 14.7 browsers allowed for Vaadin (#11821)
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add ' or 'git rm '
hint: and commit the result with 'git commit'

vaadin-bot added a commit that referenced this pull request Sep 14, 2021
@vaadin-bot
fix: make IPhone version above 14.7 browsers allowed for Vaadin (#11821…
f4b8ff4 
…) (#11835)

Fixes #11654

Co-authored-by: Denis <[email protected]>
caalador pushed a commit that referenced this pull request Sep 14, 2021
@vaadin-bot
fix: make IPhone version above 14.7 browsers allowed for Vaadin (#11821…
75fca32 
…) (#11836)

Fixes #11654

Co-authored-by: Denis <[email protected]>
denis-anisimov pushed a commit that referenced this pull request Sep 14, 2021
fix: make IPhone version above 14.7 browsers allowed for Vaadin (#11821)
282c602 
Fixes #11654
caalador pushed a commit that referenced this pull request Sep 15, 2021
fix: make IPhone version above 14.7 browsers allowed for Vaadin (#11821…
255e6aa 
…) (#11844)

Fixes #11654
vaadin-bot pushed a commit that referenced this pull request Sep 15, 2021
@vaadin-bot
fix: make IPhone version above 14.7 browsers allowed for Vaadin (#11821…
1e44532 
…) (#11844)

Fixes #11654
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with platform 22.0.0.alpha4 and is also targeting the upcoming stable 22.0.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sonatype-lift sonatype-lift[bot] sonatype-lift[bot] left review comments

@mshabarov mshabarov mshabarov approved these changes

@caalador caalador caalador approved these changes

Assignees
No one assigned
Labels
cherry-picked-7.0 cherry-picked-8.0 need to pick manually 2.6 need to pick manually 2.7 prerelease version for platform 22.0.0 Released with Platform 22.0.0.alpha4 +0.0.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Google app on iOS shows "browser too old" for Vaadin apps
4 participants
@denis-anisimov @vaadin-bot @caalador @mshabarov