Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: keep track of css injected to document (#11635) (#11673) #11793

Merged
merged 1 commit into from
Sep 9, 2021

Conversation

caalador
Copy link
Contributor

@caalador caalador commented Sep 8, 2021

Stops css/fonts from being loaded multiple times to the document with embedded applications.

Fixes #11608

Stops css/fonts from being loaded multiple times to the document with embedded applications.

Fixes #11608
# Conflicts:
#	flow-server/src/main/java/com/vaadin/flow/server/frontend/TaskUpdateImports.java
@vaadin-bot
Copy link
Collaborator

SonarQube analysis reported 6 issues

  1. CRITICAL BootstrapHandler.java#L123: Define a constant instead of duplicating this literal "//<![CDATA[\n" 3 times. rule
  2. CRITICAL BootstrapHandler.java#L124: Define a constant instead of duplicating this literal "//]]>" 3 times. rule
  3. CRITICAL BootstrapHandler.java#L591: Use already-defined constant 'SCRIPT_TAG' instead of duplicating its value here. rule
  4. MAJOR BootstrapHandler.java#L590: Call "Optional#isPresent()" before accessing the value. rule
  5. MAJOR WebComponentBootstrapHandler.java#L80: Remove this call from a constructor to the overridable "setInitTheme" method. rule
  6. MINOR WebComponentBootstrapHandler.java#L387: Remove the declaration of thrown exception 'java.io.UnsupportedEncodingException', as it cannot be thrown from method's body. rule

@mshabarov mshabarov merged commit 99a1a54 into 2.6 Sep 9, 2021
@mshabarov mshabarov deleted the cherry/cherrypick-11635-to-2.6 branch September 9, 2021 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants