fix: Remove removed items from array #11635

caalador · 2021-08-25T05:25:39Z

Remove any elements added to the
global array when the DOMNode is removed
from the dom.

Remove any elements added to the global array when the DOMNode is removed from the dom. Closes #11608

flow-server/src/main/resources/plugins/application-theme-plugin/theme-generator.js

pleku · 2021-08-25T06:57:23Z

flow-server/src/main/resources/plugins/application-theme-plugin/theme-generator.js

+    eventTarget.addEventListener('DOMNodeRemoved', event => {
+      const index = window.Vaadin['${globalCssFlag}'].indexOf(target);
+      window.Vaadin['${globalCssFlag}'].splice(index, 1);
+    });


If/when using an observer instead, it can be disconnected after the clean-up

flow-server/src/main/resources/plugins/application-theme-plugin/theme-generator.js

Do not push multiples of the same CSS to the document.

flow-server/src/main/resources/plugins/application-theme-plugin/theme-generator.js

...pplication-theme/src/test/java/com/vaadin/flow/webcomponent/ApplicationThemeComponentIT.java

Stops css/fonts from being loaded multiple times to the document with embedded applications. Closes #11608

vaadin-bot · 2021-08-27T12:44:03Z

Hi @caalador and @pleku, when i performed cherry-pick to this commit to 2.7, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 8da204a
error: could not apply 8da204a... fix: keep track of css injected to document (#11635)
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add ' or 'git rm '
hint: and commit the result with 'git commit'

Stops css/fonts from being loaded multiple times to the document with embedded applications. Closes #11608

vaadin-bot · 2021-08-27T12:44:16Z

Hi @caalador and @pleku, when i performed cherry-pick to this commit to 2.6, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 8da204a
error: could not apply 8da204a... fix: keep track of css injected to document (#11635)
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add ' or 'git rm '
hint: and commit the result with 'git commit'

Stops css/fonts from being loaded multiple times to the document with embedded applications. Closes #11608 Co-authored-by: caalador <[email protected]>

This reverts commit 8da204a.

Fixes regression caused by #11635 Fixes #11666

Fixes regression caused by #11635 Fixes #11666 Co-authored-by: Pekka Hyvönen <[email protected]>

Fixes regression caused by #11635 Fixes #11666 (cherry picked from commit 9cc240b)

Fixes regression caused by #11635 Fixes #11666 (cherry picked from commit 9cc240b) Co-authored-by: Pekka Hyvönen <[email protected]>

Stops css/fonts from being loaded multiple times to the document with embedded applications. Closes #11608 # Conflicts: # flow-server/src/main/resources/plugins/application-theme-plugin/theme-generator.js

Stops css/fonts from being loaded multiple times to the document with embedded applications. Fixes #11608

Stops css/fonts from being loaded multiple times to the document with embedded applications. Fixes #11608 # Conflicts: # flow-server/src/main/java/com/vaadin/flow/server/frontend/TaskUpdateImports.java

Stops css/fonts from being loaded multiple times to the document with embedded applications. Fixes #11608

fix: Remove removed items from array

4e8a2c1

Remove any elements added to the global array when the DOMNode is removed from the dom. Closes #11608

caalador added target/2.6 labels Aug 25, 2021

vaadin-bot added the +0.1.0 label Aug 25, 2021

tomivirkki reviewed Aug 25, 2021

View reviewed changes

flow-server/src/main/resources/plugins/application-theme-plugin/theme-generator.js Outdated Show resolved Hide resolved

pleku suggested changes Aug 25, 2021

View reviewed changes

change to observer.

588dc85

tomivirkki reviewed Aug 25, 2021

View reviewed changes

flow-server/src/main/resources/plugins/application-theme-plugin/theme-generator.js Outdated Show resolved Hide resolved

Only keep track of css injected to document.

318145c

Do not push multiples of the same CSS to the document.

caalador force-pushed the issues/11608_mem_leak branch from 1c0c745 to 318145c Compare August 26, 2021 07:31

pleku suggested changes Aug 26, 2021

View reviewed changes

caalador added 2 commits August 26, 2021 12:44

Change name, add explanation to jsdoc

81a1e29

update test name add another check

eb36753

pleku approved these changes Aug 26, 2021

View reviewed changes

pleku requested a review from tomivirkki August 26, 2021 11:30

tomivirkki approved these changes Aug 27, 2021

View reviewed changes

pleku merged commit 8da204a into master Aug 27, 2021

pleku deleted the issues/11608_mem_leak branch August 27, 2021 12:42

pleku added +0.0.1 and removed +0.1.0 labels Aug 27, 2021

vaadin-bot pushed a commit that referenced this pull request Aug 27, 2021

fix: keep track of css injected to document (#11635)

d9c2670

Stops css/fonts from being loaded multiple times to the document with embedded applications. Closes #11608

vaadin-bot added the cherry-picked-8.0 label Aug 27, 2021

vaadin-bot added the need to pick manually 2.7 label Aug 27, 2021

vaadin-bot pushed a commit that referenced this pull request Aug 27, 2021

fix: keep track of css injected to document (#11635)

e155199

Stops css/fonts from being loaded multiple times to the document with embedded applications. Closes #11608

vaadin-bot added the cherry-picked-7.0 label Aug 27, 2021

vaadin-bot added the need to pick manually 2.6 label Aug 27, 2021

Artur- added a commit that referenced this pull request Aug 27, 2021

Revert "fix: keep track of css injected to document (#11635)"

c8e010d

This reverts commit 8da204a.

Artur- mentioned this pull request Aug 27, 2021

Revert "fix: Remove removed items from array" #11667

Closed

pleku added a commit that referenced this pull request Aug 27, 2021

fix: not fail for missing window.Vaadin.Flow

9deca8a

Fixes regression caused by #11635 Fixes #11666

pleku mentioned this pull request Aug 27, 2021

fix: not fail for missing window.Vaadin.Flow #11669

Merged

pleku added a commit that referenced this pull request Aug 27, 2021

fix: not fail for missing window.Vaadin.Flow (#11669)

9cc240b

Fixes regression caused by #11635 Fixes #11666

vaadin-bot pushed a commit that referenced this pull request Aug 27, 2021

fix: not fail for missing window.Vaadin.Flow (#11669)

4aba3b5

Fixes regression caused by #11635 Fixes #11666

vaadin-bot added a commit that referenced this pull request Aug 28, 2021

fix: not fail for missing window.Vaadin.Flow (#11669) (#11670)

2d600d9

Fixes regression caused by #11635 Fixes #11666 Co-authored-by: Pekka Hyvönen <[email protected]>

mshabarov pushed a commit that referenced this pull request Aug 29, 2021

fix: not fail for missing window.Vaadin.Flow (#11669)

caebcb7

Fixes regression caused by #11635 Fixes #11666 (cherry picked from commit 9cc240b)

mshabarov mentioned this pull request Aug 29, 2021

fix: not fail for missing window.Vaadin.Flow (CP: 7.0) #11672

Merged

9 tasks

caalador pushed a commit that referenced this pull request Aug 30, 2021

fix: not fail for missing window.Vaadin.Flow (#11669) (#11672)

6135e21

Fixes regression caused by #11635 Fixes #11666 (cherry picked from commit 9cc240b) Co-authored-by: Pekka Hyvönen <[email protected]>

mshabarov pushed a commit that referenced this pull request Sep 7, 2021

fix: keep track of css injected to document (#11635) (#11673)

204d2cf

Stops css/fonts from being loaded multiple times to the document with embedded applications. Fixes #11608

vaadin-bot mentioned this pull request Sep 7, 2021

fix: keep track of css injected to document (#11635) #11673

Merged

mshabarov pushed a commit that referenced this pull request Sep 9, 2021

fix: keep track of css injected to document (#11635) (#11673) (#11793)

99a1a54

Stops css/fonts from being loaded multiple times to the document with embedded applications. Fixes #11608

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Remove removed items from array #11635

fix: Remove removed items from array #11635

caalador commented Aug 25, 2021

pleku Aug 25, 2021

vaadin-bot commented Aug 27, 2021

vaadin-bot commented Aug 27, 2021

fix: Remove removed items from array #11635

fix: Remove removed items from array #11635

Conversation

caalador commented Aug 25, 2021

pleku Aug 25, 2021

Choose a reason for hiding this comment

vaadin-bot commented Aug 27, 2021

vaadin-bot commented Aug 27, 2021