Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: check the component belongs to UI before task execution (#11726) (CP: 7.0) #11788

Merged
merged 1 commit into from
Sep 9, 2021
Merged

fix: check the component belongs to UI before task execution (#11726) (CP: 7.0) #11788

merged 1 commit into from
Sep 9, 2021

Conversation

vaadin-bot
Copy link
Collaborator

No description provided.

@vaadin-bot
Copy link
Collaborator Author

SonarQube analysis reported 3 issues

  1. MAJOR UI.java#L1014: Call "Optional#isPresent()" before accessing the value. rule
  2. MINOR UI.java#L1003: Remove the declaration of thrown exception 'java.lang.IllegalArgumentException' which is a runtime exception. rule
  3. INFO UI.java#L968: Do not forget to remove this deprecated code someday. rule

@denis-anisimov denis-anisimov merged commit 8768346 into 7.0 Sep 9, 2021
@denis-anisimov denis-anisimov deleted the cherry-pick-11726-to-7.0-1631017507636 branch September 9, 2021 10:33
@vaadin-bot
Copy link
Collaborator Author

This ticket/PR has been released with platform 20.0.8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denis-anisimov denis-anisimov denis-anisimov approved these changes

Assignees
No one assigned
Labels
Released with Platform 20.0.8 +0.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vaadin-bot @denis-anisimov @mshabarov