fix: check the component belongs to UI before task execution #11726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denis-anisimov
suggested changes
Sep 6, 2021
| @@ -995,6 +995,8 @@ public Router getRouter() { | |||
| * | |||
| * @return a registration that can be used to cancel the execution of the | |||
| * task | |||
| * @throws IllegalArgumentException | |||
| * if the given component doesn't belong to this UI | |||
| */ | |||
| public ExecutionRegistration beforeClientResponse(Component component, | |||
There was a problem hiding this comment.
the method should have throws: javadoc is not necessary but if you extend javadocs then the method should throws .
|
SonarQube analysis reported 3 issues
|
denis-anisimov
approved these changes
Sep 6, 2021
vaadin-bot
pushed a commit
that referenced
this pull request
Sep 7, 2021
vaadin-bot
pushed a commit
that referenced
this pull request
Sep 7, 2021
vaadin-bot
pushed a commit
that referenced
this pull request
Sep 7, 2021
vaadin-bot
pushed a commit
that referenced
this pull request
Sep 7, 2021
denis-anisimov
pushed a commit
that referenced
this pull request
Sep 9, 2021
…#11788) Related-to #11599 Co-authored-by: Mikhail Shabarov <[email protected]>
denis-anisimov
pushed a commit
that referenced
this pull request
Sep 9, 2021
denis-anisimov
pushed a commit
that referenced
this pull request
Sep 9, 2021
denis-anisimov
pushed a commit
that referenced
this pull request
Sep 9, 2021
|
This ticket/PR has been released with platform 21.0.2. |
|
This ticket/PR has been released with platform 14.7.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds an assumption that the given component belongs to UI instance on which the task is going to be executed. This is needed to fail-fast and detect errors earlier before the actual task is executed and throws because of inconsistency in
StateTree.Related-to #11599
Type of change
Checklist
Additional for
Featuretype of change