Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fixes comparison of prerelease versions FE deps (#11353) (#11364) (CP: 2.6) #11366

Merged
merged 1 commit into from
Jun 30, 2021
Merged

fix: fixes comparison of prerelease versions FE deps (#11353) (#11364) (CP: 2.6) #11366

merged 1 commit into from
Jun 30, 2021

Conversation

vaadin-bot
Copy link
Collaborator

No description provided.

@caalador @vaadin-bot
fix: fixes comparison of prerelease versions FE deps (#11353) (#11364)
53d5fc5 
Fix buildIdentifier comparison so values compare correctly.
The problem caused e.g. alphas greater than 10 to be considered older than 2-9.

fixes #11352
@vaadin-bot
Copy link
Collaborator Author

This PR is eligible for auto-merging policy, so it has been approved automatically.[Message is sent from bot]

@vaadin-bot vaadin-bot merged commit 422648a into 2.6 Jun 30, 2021
@vaadin-bot
Copy link
Collaborator Author

This PR has been merged with 'squash' method.[Message is sent from bot]

@vaadin-bot vaadin-bot deleted the cherry-pick-11364-to-2.6-1625051661651 branch June 30, 2021 12:56
@vaadin-bot
Copy link
Collaborator Author

This ticket/PR has been released with platform 14.6.6. For prerelease versions, it will be included in its final version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaadin-review-bot vaadin-review-bot vaadin-review-bot approved these changes

Assignees
No one assigned
Labels
Released with Platform 14.6.6 +0.0.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vaadin-bot @vaadin-review-bot @caalador