Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Faulty comparison for buildIdentifier in FrontendVersion #11352

Closed
caalador opened this issue Jun 29, 2021 · 4 comments · Fixed by #11353
Closed

Faulty comparison for buildIdentifier in FrontendVersion #11352

caalador opened this issue Jun 29, 2021 · 4 comments · Fixed by #11353
Assignees
@caalador
Labels
bug Impact: Low prerelease version for platform 14.7.0 prerelease version for platform 21.0.0 Released with Platform 14.6.6 Released with Platform 14.7.0.alpha3 Released with Platform 20.0.4 Released with Platform 21.0.0.beta1 Severity: Major

Comments

@caalador
Copy link
Contributor

FrontendVersion compares wrong the version when comparing the buildIdentifier string.

With input
new FrontendVersion("2.0.0-alpha6").isOlderThan(new FrontendVersion("2.0.0-alpha13"))
Expected
true
Actual
false
@caalador caalador self-assigned this Jun 29, 2021
caalador added a commit that referenced this issue Jun 29, 2021
@caalador
fix: Update buildIdentifier comparison
7f20d97 
Fix buildIdentifier comparison so
values comaper correctly.

fixes #11352
caalador added a commit that referenced this issue Jun 29, 2021
@caalador
fix: Update buildIdentifier comparison
391f2f4 
Fix buildIdentifier comparison so
values compare correctly.

fixes #11352
@caalador caalador mentioned this issue Jun 29, 2021
Merged
caalador added a commit that referenced this issue Jun 29, 2021
@caalador
fix: Update buildIdentifier comparison
d98e05d 
Fix buildIdentifier comparison so
values compare correctly.

fixes #11352
caalador added a commit that referenced this issue Jun 29, 2021
@caalador
fix: Update buildIdentifier comparison
e410325 
Fix buildIdentifier comparison so
values compare correctly.

fixes #11352
pleku pushed a commit that referenced this issue Jun 30, 2021
@caalador
fix: fixes comparison of prerelease versions FE deps (#11353)
d79a88d 
Fix buildIdentifier comparison so values compare correctly.
The problem caused e.g. alphas greater than 10 to be considered older than 2-9.

fixes #11352
vaadin-bot pushed a commit that referenced this issue Jun 30, 2021
@caalador @vaadin-bot
fix: fixes comparison of prerelease versions FE deps (#11353)
0793bd7 
Fix buildIdentifier comparison so values compare correctly.
The problem caused e.g. alphas greater than 10 to be considered older than 2-9.

fixes #11352
vaadin-bot added a commit that referenced this issue Jun 30, 2021
@vaadin-bot @caalador
fix: fixes comparison of prerelease versions FE deps (#11353) (#11361)
4928aa0 
Fix buildIdentifier comparison so values compare correctly.
The problem caused e.g. alphas greater than 10 to be considered older than 2-9.

fixes #11352

Co-authored-by: caalador <[email protected]>
caalador added a commit that referenced this issue Jun 30, 2021
@caalador
fix: fixes comparison of prerelease versions FE deps (#11353)
6029663 
Fix buildIdentifier comparison so values compare correctly.
The problem caused e.g. alphas greater than 10 to be considered older than 2-9.

fixes #11352
# Conflicts:
#	flow-server/src/main/java/com/vaadin/flow/server/frontend/FrontendVersion.java
@caalador caalador mentioned this issue Jun 30, 2021
Merged
pleku pushed a commit that referenced this issue Jun 30, 2021
@caalador
fix: fixes comparison of prerelease versions FE deps (#11353) (#11364)
d8b262c 
Fix buildIdentifier comparison so values compare correctly.
The problem caused e.g. alphas greater than 10 to be considered older than 2-9.

fixes #11352
vaadin-bot pushed a commit that referenced this issue Jun 30, 2021
@caalador @vaadin-bot
fix: fixes comparison of prerelease versions FE deps (#11353) (#11364)
53d5fc5 
Fix buildIdentifier comparison so values compare correctly.
The problem caused e.g. alphas greater than 10 to be considered older than 2-9.

fixes #11352
vaadin-bot added a commit that referenced this issue Jun 30, 2021
@vaadin-bot @caalador
fix: fixes comparison of prerelease versions FE deps (#11353) (#11364) (
422648a 
#11366)

Fix buildIdentifier comparison so values compare correctly.
The problem caused e.g. alphas greater than 10 to be considered older than 2-9.

fixes #11352

Co-authored-by: caalador <[email protected]>
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with platform 20.0.4. For prerelease versions, it will be included in its final version.

@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with platform 14.6.6. For prerelease versions, it will be included in its final version.

@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with platform 21.0.0.beta1 and is also targeting the upcoming stable 21.0.0 version.

@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with platform 14.7.0.alpha3 and is also targeting the upcoming stable 14.7.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@caalador caalador

Labels
bug Impact: Low prerelease version for platform 14.7.0 prerelease version for platform 21.0.0 Released with Platform 14.6.6 Released with Platform 14.7.0.alpha3 Released with Platform 20.0.4 Released with Platform 21.0.0.beta1 Severity: Major
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Update buildIdentifier comparison vaadin/flow
2 participants
@caalador @vaadin-bot