Bring in reusable theme feature and tests #10197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a tests for checking that the document.css file is injected to the document scope and not injected to embedded element shadow root. Fixes #9552
Now there is a possibility to use the "documentCss" key in theme.json to inject npm css into the document rool level element. This is mostly for embedded web components as they do not target document by default Fixes #9533 * Use more targeted bookkeeping for globalCss Have a full map on where the global css has been injected to so that if we add for shadow roots we don't add to document, but we are able to add to other shadow roots. # Conflicts: # flow-server/src/main/java/com/vaadin/flow/server/AppShellRegistry.java # flow-server/src/test/java/com/vaadin/flow/server/startup/VaadinAppShellInitializerTest.java
The file-loader didn't handle otf extensions so having a otf font-face failed the build. Fixes #9683
Resolves #9585 # Conflicts: # flow-server/src/main/java/com/vaadin/flow/server/frontend/TaskCopyFrontendFiles.java # flow-server/src/main/java/com/vaadin/flow/server/frontend/TaskUpdateThemeImport.java # flow-tests/pom.xml
Add a reusable theme module for embedded tests. Add module to test using reusable theme from dependency with embedded application. Fixes: #9828 # Conflicts: # flow-tests/test-embedding/pom.xml
caalador
force-pushed
the
issues/9983_reusable_theme
branch
from
9bb34cb to
12bdbfc
Compare
|
SonarQube analysis reported 50 issues
Top 10 extra issuesNote: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:
|
pleku
reviewed
Mar 8, 2021
...g-reusable-theme/src/test/java/com/vaadin/flow/webcomponent/ApplicationThemeComponentIT.java
Show resolved
Hide resolved
pleku
approved these changes
Mar 8, 2021
|
This probably needs to be squashed ? Not all commits in history follow the messaage syntax |
|
Well they are as they were in master. |
|
It could be fixed by f-p but the release notes will need to be cleaned up a bit anyway so I don't think it matters so much |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #9983