-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom theme feature backporting from master to 2.6 #9983
Comments
Having an empty |
Throw exception if improved theme support is used in compatibility mode. Part of #9983
Throw exception if improved theme support is used in compatibility mode. Part of #9983
Another thing to TODO, update the project used for PiT to use 14.6 |
Created branch: https://gitlab.vaadin.com/mgrankvi/appthemedx/-/tree/14.6/ |
Note: #9613 adds css loading order tests, and for some reason they load differently under V14.
|
Add the custom theme feature documentation to v14 branch. Part of vaadin/flow#9983
Add the custom theme feature documentation to v14 branch. Part of vaadin/flow#9983
Add the custom theme feature documentation to v14 branch. Part of vaadin/flow#9983
Add the custom theme feature documentation to v14 branch. Part of vaadin/flow#9983
Add the custom theme feature documentation to v14 branch. Part of vaadin/flow#9983
Add the custom theme feature documentation to v14 branch. Part of vaadin/flow#9983
Add the custom theme feature documentation to v14 branch. Part of vaadin/flow#9983
Add the custom theme feature documentation to v14 branch. Part of vaadin/flow#9983
this means that we make the default
value
beLumo.class
.What this implies is that:
@Theme(themeFolder="foobar")
when in compatibility mode, we should throw an error noting that custom themes don't' t work in compatibility modeIf there are things that are only applicable for fusion projects, like maybe #9842, those don't have to backported to 14.
Adding the custom theme feature should not regress the frontend build time for v14. The plugins should not be applied when the custom theme folder is not in use.
The text was updated successfully, but these errors were encountered: