Inconsistency in MenuData.icon between Flow and Hilla views without icon #20114
Assignees
Labels
Comments
mshabarov
moved this to 🔖 High Priority (P1)
in Vaadin Flow bugs & maintenance (Vaadin 10+)
tltv
added a commit
that referenced
this issue
Oct 3, 2024
tepi
pushed a commit
that referenced
this issue
Oct 4, 2024
github-project-automation
bot
moved this from 🔖 High Priority (P1)
to ✅ Closed
in Vaadin Flow bugs & maintenance (Vaadin 10+)
github-project-automation
bot
moved this from 🟢Ready to Go
to Done
in Vaadin Flow ongoing work (Vaadin 10+)
vaadin-bot
pushed a commit
that referenced
this issue
Oct 4, 2024
vaadin-bot
added a commit
that referenced
this issue
Oct 4, 2024
Fixes: #20114 Co-authored-by: Tomi Virtanen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description of the bug
For a Flow view without an icon (i.e. just a plain
@Menu),MenuData.iconcontains""whereas a Hilla view without icon (i.e.export const config = { menu: {} }) hasnull.Expected behavior
Expected that the same value is used in both cases so that application logic that renders the menu doesn't have to check for both cases.
Minimal reproducible example
24.5 pre starter from Start
Versions
The text was updated successfully, but these errors were encountered: