-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate MenuItems api for application menu generation #20063
Labels
Comments
mshabarov
moved this to Next for Dev. Team
in Vaadin Flow enhancements backlog (Vaadin 10+)
Sep 30, 2024
Acceptance Criteria (draft)
|
Should this include a reference to the class from which the menu comes from? Custom Menu Annotations are probably a bit hard to support.. but this would at least allow to gather all other annotation / informations from the Menu's class. |
Sounds like a useful data to have there, agreed. |
tltv
moved this from 🪵Product backlog
to ⚒️ In progress
in Vaadin Flow ongoing work (Vaadin 10+)
Oct 3, 2024
tltv
added a commit
that referenced
this issue
Oct 3, 2024
New public API for building application menu: adds `MenuConfiguration`, `MenuOptions` and `MenuOption` where `MenuConfiguration` is the main entry point to access menu data to build main menu. Fixes: #20063
tltv
added a commit
that referenced
this issue
Oct 3, 2024
New public API for building application menu: adds `MenuConfiguration`, `MenuOptions` and `MenuOption` where `MenuConfiguration` is the main entry point to access menu data to build main menu. Fixes: #20063
tltv
added a commit
that referenced
this issue
Oct 4, 2024
New public API for building application menu: adds `MenuConfiguration`, `MenuOptions` and `MenuOption` where `MenuConfiguration` is the main entry point to access menu data to build main menu. Fixes: #20063
tltv
added a commit
that referenced
this issue
Oct 4, 2024
New public API for building application menu: adds `MenuConfiguration`, `MenuOptions` and `MenuOption` where `MenuConfiguration` is the main entry point to access menu data to build main menu. Fixes: #20063
tltv
added a commit
to vaadin/hilla
that referenced
this issue
Oct 4, 2024
github-project-automation
bot
moved this from ⚒️ In progress
to Done
in Vaadin Flow ongoing work (Vaadin 10+)
Oct 4, 2024
github-project-automation
bot
moved this from Next for Dev. Team
to Done / Pending Release
in Vaadin Flow enhancements backlog (Vaadin 10+)
Oct 4, 2024
vaadin-bot
pushed a commit
that referenced
this issue
Oct 4, 2024
* feat: add MenuConfiguration New public API for building application menu: adds `MenuConfiguration`, `MenuOptions` and `MenuOption` where `MenuConfiguration` is the main entry point to access menu data to build main menu. Fixes: #20063 * chore: renamed classes and removed MenuOptions Renamed MenuOption to MenuEntry. * chore: updated javadocs * chore: moved MenuRegistry to internal package Removed Serializable from MenuConfiguration. * chore: added javadoc and deprecated MenuData constructor * chore: use new constructor * chore: make MenuConfiguration final
mshabarov
pushed a commit
that referenced
this issue
Oct 4, 2024
* feat: add MenuConfiguration New public API for building application menu: adds `MenuConfiguration`, `MenuOptions` and `MenuOption` where `MenuConfiguration` is the main entry point to access menu data to build main menu. Fixes: #20063 * chore: renamed classes and removed MenuOptions Renamed MenuOption to MenuEntry. * chore: updated javadocs * chore: moved MenuRegistry to internal package Removed Serializable from MenuConfiguration. * chore: added javadoc and deprecated MenuData constructor * chore: use new constructor * chore: make MenuConfiguration final Co-authored-by: Tomi Virtanen <[email protected]>
taefi
pushed a commit
to vaadin/hilla
that referenced
this issue
Oct 7, 2024
* chore: update imports to MenuRegistry RelatedTo: vaadin/flow/issues/20063 * chore: fixed tests --------- Co-authored-by: Artur <[email protected]>
tltv
added a commit
to vaadin/docs
that referenced
this issue
Oct 7, 2024
Renamed menu-registry to menu-configuration. Updated content to match with new simpler public API of MenuConfiguration. MenuRegistry was changed to internal API and only new public API is documented. RelatedTo: vaadin/flow#20063
russelljtdyer
added a commit
to vaadin/docs
that referenced
this issue
Oct 14, 2024
* docs: document MenuConfiguration Renamed menu-registry to menu-configuration. Updated content to match with new simpler public API of MenuConfiguration. MenuRegistry was changed to internal API and only new public API is documented. RelatedTo: vaadin/flow#20063 * Updated by review comments * First pass at editing new document. * Second pass at editing. * A few more minor edits. --------- Co-authored-by: Russell J.T. Dyer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe your motivation
There exists the MenuRegistry that can be used for collecting menu item and route data, but the implementation is aimed for internal consumption and is not as user friendly as it could be.
Describe the solution you'd like
There should be a
MenuConfiguration
class that returnsMenuOptions
objects as an ordered collection for use within applications.Describe alternatives you've considered
Update and remake the current MenuRegistry api.
The text was updated successfully, but these errors were encountered: