Vaadin 24.4.9 RouterLink in Drawer #19823
Assignees
Comments
|
This is probably a regression after some other fix, as #18736 aimed to fix the same problem. |
|
Confirmed this is a regression on latest versions and on 24.5 branch as well. Investigating. |
caalador
added a commit
that referenced
this issue
Sep 19, 2024
Close the overlay drawer even when clicking on same link and no actual navigation happens. Fixes #19823
vaadin-bot
pushed a commit
that referenced
this issue
Sep 20, 2024
* fix: close overlay drawer on click Close the overlay drawer even when clicking on same link and no actual navigation happens. Fixes #19823 * reset fromAnchor for navigation This in case the flag has for some reason not been reset after a click.
vaadin-bot
pushed a commit
that referenced
this issue
Sep 20, 2024
* fix: close overlay drawer on click Close the overlay drawer even when clicking on same link and no actual navigation happens. Fixes #19823 * reset fromAnchor for navigation This in case the flag has for some reason not been reset after a click.
vaadin-bot
added a commit
that referenced
this issue
Sep 20, 2024
* fix: close overlay drawer on click Close the overlay drawer even when clicking on same link and no actual navigation happens. Fixes #19823 * reset fromAnchor for navigation This in case the flag has for some reason not been reset after a click. Co-authored-by: caalador <[email protected]>
vaadin-bot
added a commit
that referenced
this issue
Sep 20, 2024
* fix: close overlay drawer on click Close the overlay drawer even when clicking on same link and no actual navigation happens. Fixes #19823 * reset fromAnchor for navigation This in case the flag has for some reason not been reset after a click. Co-authored-by: caalador <[email protected]>
|
This ticket/PR has been released with Vaadin 24.5.0.beta2 and is also targeting the upcoming stable 24.5.0 version. |
|
This ticket/PR has been released with Vaadin 24.4.13. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description of the bug
Previous similar bug #18736
With Vaadin 24.4.9, when I click on the RouterLink which points to the page where I currently am, the Drawer on the mobile view does not close, unlike in version 24.4.0.beta5 :
Expected behavior
The drawer on the mobile view should be closed after the click, even if it is pointed to the page where the user currently is
Minimal reproducible example
n/a
Versions
The text was updated successfully, but these errors were encountered: