-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple redundant invocations of the method com.vaadin.flow.router.HasUrlParameter#setParameter in Vaadin 24.4.9 #19822
Comments
Sorry to bother you, but is there a chance this will be fixed anytime soon? |
Seems this is another issue with the We are looking into these problems with |
Thank you! Unfortunately, along with this issue, I am also blocked from updating with this one as well #19823 |
@tepi Hi! Could you please tell me in which version this fix will be released? |
Hi! The fix is released in 24.5.0.beta2 and will be released in Flow 24.4.9 which should be released within a week as part of Vaadin 24.4.13. |
@tepi Thank you! Sorry for bothering you with additional questions – but do I need to change anything in the code to switch from version 24.4.* to 24.5.* or should it go smoothly? |
There should not be breaking changes between those versions, version update is enough. |
This ticket/PR has been released with Vaadin 24.4.13. |
Hi @tepi I just upgraded to Vaadin 24.4.13, and unfortunately, the issue with the repeated triggering of |
Could you provide some more context on how to reproduce the issue? Using Vaadin 24.4.13 and the original example from this ticket, as well as the test built for this issue, there is only one call. So I suspect that there is something in your case that has not been revealed in this ticket yet. |
@tepi I think I've localized the problem. In my previous example (with which I created this ticket), everything remains the same. If I simply directly go to localhost:8080/administration in the browser address bar, everything works correctly, even with forwarding— But I also have
And now, when I click on this RouterLink, I get two calls to the I hope this helps you localize the issue. |
Confirmed. Judging from browser console, all seems to be fine in the uidl response: a |
@tepi Thank you very much for correcting this! Could you please let me know in which release version this fix is expected? |
Thanks to @mcollovati for the latest fix. This will be released in next 24.4 and 24.5 branch releases; Vaadin 24.4.14 and the first RC for Vaadin 24.5. Both should happen within a week. |
…tion is completed (#20187) (#20195) Fixes #19822 Co-authored-by: Marco Collovati <[email protected]>
…tion is completed (#20187) (CP: 24.4) (#20196) * fix: perform server navigation roundtrip only when client side navigation is completed (#20187) Fixes #19822 * format --------- Co-authored-by: Marco Collovati <[email protected]>
Description of the bug
I have an AdministrationView:
Available at the following URL:
http://localhost:8080/administration
As you can see, in the
beforeEnter
method, there is a forward toAdministrationRecruitersView.class
.The
AdministrationRecruitersView.class
itself is implemented as:So, when navigating to AdministrationView (by http://localhost:8080/administration) and subsequently auto forwarding to AdministrationRecruitersView, the method AdministrationRecruitersView.setParameter() is called 3 times in a row. If I navigate directly to AdministrationRecruitersView, i.e., to http://localhost:8080/administration/recruiters, the method AdministrationRecruitersView.setParameter() is correctly called only once, as it should be.
This issue started appearing in version 24.4.9, while in version 24.4.0.beta5 everything works correctly. I haven't changed anything in my code.
Also, in version 24.4.9, the bug from #18736 has reappeared, but it’s not present in version 24.4.0.beta5, where everything works fine.
Expected behavior
no redundant invocation of com.vaadin.flow.router.HasUrlParameter#setParameter
Minimal reproducible example
n/a
Versions
The text was updated successfully, but these errors were encountered: