This repository has been archived by the owner on May 6, 2021. It is now read-only.
Add theme variants documentation #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denis-anisimov
suggested changes
Jul 19, 2018
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1.
Reviewable status: 2 unresolved discussions, 0 of 1 LGTMs obtained
documentation/src/main/html/ThemeVariants.html, line 2 at r1 (raw file):
tutorial::theme/using-component-themes.asciidoc <vaadin-button theme="contrast primary">Themed button</vaadin-button>
new line
documentation/theme/using-component-themes.asciidoc, line 191 at r1 (raw file):
As was mentioned earlier, by default, if no explicit theme configuration is done and `vaadin-lumo-theme` dependency is present in the classpath, LumoTheme is used.
new line
SomeoneToIgnore
commented
Jul 19, 2018
There was a problem hiding this comment.
Reviewable status: 2 unresolved discussions, 0 of 1 LGTMs obtained
documentation/src/main/html/ThemeVariants.html, line 2 at r1 (raw file):
Previously, denis-anisimov (Denis) wrote…
new line
Done.
documentation/theme/using-component-themes.asciidoc, line 191 at r1 (raw file):
Previously, denis-anisimov (Denis) wrote…
new line
Done.
denis-anisimov
approved these changes
Jul 19, 2018
There was a problem hiding this comment.
Reviewed 2 of 2 files at r2.
Reviewable status: all discussions resolved, 0 of 1 LGTMs obtained, and 1 stale
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of vaadin/flow#4318
This change is