Skip to content
This repository has been archived by the owner on May 6, 2021. It is now read-only.

Use addThemeVariants in documentation #367

Closed
Peppe opened this issue Dec 14, 2018 · 2 comments
Closed

Use addThemeVariants in documentation #367

Peppe opened this issue Dec 14, 2018 · 2 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed tutorial
Milestone

Comments

@Peppe
Copy link
Contributor

Peppe commented Dec 14, 2018

Vaadin 12 brought us the handy componentaddThemeVariants(String) method for components. However in the documentation there is still usage of button.getElement().setAttribute("theme", "contrast primary"); at least in https://vaadin.com/docs/v12/flow/theme/using-component-themes.html. Update examples across the board to use the new API .

@Legioth Legioth transferred this issue from vaadin/flow Dec 14, 2018
@pleku pleku added help wanted Extra attention is needed good first issue Good for newcomers tutorial labels Dec 14, 2018
@DiegoSanzVi
Copy link
Contributor

There was already a commit about it: "Add theme variants documentation (#216)"

In the documentation, he mentioned the old way as an alternative,

"If you want more flexibility (which may come in handy when adding non-standard theme variants to the component), you can manipulate the value of the theme attribute directly:"

b214e41#diff-268e59436474fb538c76d41f7c8715f8

Should this issue be closed?

@ZheSun88
Copy link
Contributor

As Diego said, This ticket has been completed. closed.

@ZheSun88 ZheSun88 added this to the Abandoned milestone Mar 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers help wanted Extra attention is needed tutorial
Projects
None yet
Development

No branches or pull requests

4 participants