Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix serialization issues #438

Merged
merged 2 commits into from
Jun 26, 2023
Merged

Conversation

mcollovati
Copy link
Contributor

Description

Fixes serialization issues

Fixes #436
Fixes #437

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

pom.xml Outdated
Comment on lines 187 to 191
<dependency>
<groupId>org.mockito</groupId>
<artifactId>mockito-inline</artifactId>
<version>${mockito.version}</version>
</dependency>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we just update mockito to 5.4.0 to get rid of inline as that would have it baked in already?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! I'll bump the version

@caalador caalador merged commit 7475549 into main Jun 26, 2023
@caalador caalador deleted the issues/436_437_serialization_issues branch June 26, 2023 09:55
@vaadin-bot
Copy link

Hi @mcollovati and @caalador, when i performed cherry-pick to this commit to 11.3, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 7475549
error: could not apply 7475549... fix: fix serialization issues (#438)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

@vaadin-bot
Copy link

Hi @mcollovati and @caalador, when i performed cherry-pick to this commit to 14.1, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 7475549
error: could not apply 7475549... fix: fix serialization issues (#438)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

mcollovati added a commit that referenced this pull request Jun 28, 2023
mcollovati added a commit that referenced this pull request Jun 28, 2023
mcollovati added a commit that referenced this pull request Jun 28, 2023
mcollovati added a commit that referenced this pull request Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Serialization issue with UIEventListener RouteScopedContext.NavigationData is not serializable
3 participants