Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Serialization issue with UIEventListener #437

Closed
mcollovati opened this issue Jun 15, 2023 · 14 comments · Fixed by #438
Closed

Serialization issue with UIEventListener #437

mcollovati opened this issue Jun 15, 2023 · 14 comments · Fixed by #438
Assignees
@mcollovati
Labels
bug Impact: High prerelease version for Vaadin 14.11.0 prerelease version for Vaadin 14.12.0 prerelease version for Vaadin 22.2.0 prerelease version for Vaadin 23.4.0 prerelease version for Vaadin 23.5.0 prerelease version for Vaadin 24.2.0 prerelease version for Vaadin 24.3.0 prerelease version for Vaadin 24.4.0 prerelease version for Vaadin 24.5.0 Released with Vaadin 14.10.3 Released with Vaadin 14.11.0.alpha1 Released with Vaadin 14.12.0.alpha1 Released with Vaadin 22.1.1 Released with Vaadin 22.2.0.alpha1 Released with Vaadin 23.3.16 Released with Vaadin 23.4.0.alpha1 Released with Vaadin 23.5.0.alpha1 Released with Vaadin 24.0.9 Released with Vaadin 24.1.2 Released with Vaadin 24.2.0.alpha2 Released with Vaadin 24.3.0.alpha1 Released with Vaadin 24.4.0.alpha1 Released with Vaadin 24.5.0.alpha1 Severity: Major

Comments

@mcollovati
Copy link
Contributor

CdiVaadinServletService installs an instance of UIEventListener to listen to UI events.
However, the listener holds a reference to VaadinService through a CdiVaadinServiceDelegate instance.

VaadinService is not supposed to be stored in the HTTP session, and it also contains a reference to a ClassLoader instance, that is not serializable.

Either the UIEventListener should declare its CdiVaadinServiceDelegate field as transient, or the CdiVaadinServiceDelegate should mark its VaadinService reference as transient.

It should be checked if/how the VaadinService instance should be restored upon deserialization.
@mcollovati mcollovati self-assigned this Jun 21, 2023
mcollovati added a commit that referenced this issue Jun 21, 2023
@mcollovati
fix: fix serialization issues
1dee606 
Fixes #436
Fixes #437
@mcollovati mcollovati mentioned this issue Jun 21, 2023
Merged
9 tasks
caalador pushed a commit that referenced this issue Jun 26, 2023
@mcollovati
fix: fix serialization issues (#438)
7475549 
Fixes #436
Fixes #437
mcollovati added a commit that referenced this issue Jun 28, 2023
@mcollovati
fix: fix serialization issues (#438)
82786c4 
Fixes #436
Fixes #437
@mcollovati mcollovati mentioned this issue Jun 28, 2023
Merged
mcollovati added a commit that referenced this issue Jun 28, 2023
@mcollovati
fix: fix serialization issues (#438)
3643693 
Fixes #436
Fixes #437
@mcollovati mcollovati mentioned this issue Jun 28, 2023
Merged
mcollovati added a commit that referenced this issue Jun 28, 2023
@mcollovati
fix: fix serialization issues (#438) (#440)
79ba476 
Fixes #436
Fixes #437
mcollovati added a commit that referenced this issue Jun 28, 2023
@mcollovati
fix: fix serialization issues (#438) (#439)
df0acd3 
Fixes #436
Fixes #437
mcollovati added a commit that referenced this issue Jun 29, 2023
@mcollovati
fix: fix serialization issues
eba7268 
Fixes #436
Fixes #437
@mcollovati mcollovati mentioned this issue Jun 29, 2023
Merged
mshabarov pushed a commit that referenced this issue Jun 29, 2023
@mcollovati
fix: fix serialization issues (#442)
87289d8 
Fixes #436
Fixes #437
@vaadin-bot
Copy link

This ticket/PR has been released with Vaadin 14.10.3.

@vaadin-bot
Copy link

This ticket/PR has been released with Vaadin 22.1.1.

@vaadin-bot
Copy link

This ticket/PR has been released with Vaadin 23.3.16.

@vaadin-bot
Copy link

This ticket/PR has been released with Vaadin 24.0.9.

@vaadin-bot
Copy link

This ticket/PR has been released with Vaadin 24.1.2.

@vaadin-bot
Copy link

This ticket/PR has been released with Vaadin 24.2.0.alpha2 and is also targeting the upcoming stable 24.2.0 version.

@vaadin-bot
Copy link

This ticket/PR has been released with Vaadin 14.11.0.alpha1 and is also targeting the upcoming stable 14.11.0 version.

@vaadin-bot
Copy link

This ticket/PR has been released with Vaadin 24.3.0.alpha1 and is also targeting the upcoming stable 24.3.0 version.

@vaadin-bot
Copy link

This ticket/PR has been released with Vaadin 22.2.0.alpha1 and is also targeting the upcoming stable 22.2.0 version.

@vaadin-bot
Copy link

This ticket/PR has been released with Vaadin 23.4.0.alpha1 and is also targeting the upcoming stable 23.4.0 version.

@vaadin-bot
Copy link

This ticket/PR has been released with Vaadin 24.4.0.alpha1 and is also targeting the upcoming stable 24.4.0 version.

@vaadin-bot
Copy link

This ticket/PR has been released with Vaadin 23.5.0.alpha1 and is also targeting the upcoming stable 23.5.0 version.

@vaadin-bot
Copy link

This ticket/PR has been released with Vaadin 24.5.0.alpha1 and is also targeting the upcoming stable 24.5.0 version.

@vaadin-bot
Copy link

This ticket/PR has been released with Vaadin 14.12.0.alpha1 and is also targeting the upcoming stable 14.12.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mcollovati mcollovati

Labels
bug Impact: High prerelease version for Vaadin 14.11.0 prerelease version for Vaadin 14.12.0 prerelease version for Vaadin 22.2.0 prerelease version for Vaadin 23.4.0 prerelease version for Vaadin 23.5.0 prerelease version for Vaadin 24.2.0 prerelease version for Vaadin 24.3.0 prerelease version for Vaadin 24.4.0 prerelease version for Vaadin 24.5.0 Released with Vaadin 14.10.3 Released with Vaadin 14.11.0.alpha1 Released with Vaadin 14.12.0.alpha1 Released with Vaadin 22.1.1 Released with Vaadin 22.2.0.alpha1 Released with Vaadin 23.3.16 Released with Vaadin 23.4.0.alpha1 Released with Vaadin 23.5.0.alpha1 Released with Vaadin 24.0.9 Released with Vaadin 24.1.2 Released with Vaadin 24.2.0.alpha2 Released with Vaadin 24.3.0.alpha1 Released with Vaadin 24.4.0.alpha1 Released with Vaadin 24.5.0.alpha1 Severity: Major
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: fix serialization issues vaadin/cdi
3 participants
@mcollovati @vaadin-bot @mshabarov