Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storybookのアップデート #269

Merged
merged 12 commits into from
Jul 14, 2023
Merged

Storybookのアップデート #269

merged 12 commits into from
Jul 14, 2023

Conversation

takashi0602
Copy link
Member

@takashi0602 takashi0602 commented Jul 13, 2023

close #167 close #225 close #149

概要

Storybookのアップデートに伴い主に以下を対応しました。

  • Storybook v6系からv7系にする
  • storybook-addon-nextを辞め@storybook/nextjsを使用する
  • @vanilla-extract/babel-pluginの削除と.babelrcの削除
  • .storybook/main.jsをmain.tsにする
  • storiesファイル内での非推奨になった記述を辞める
  • ESLint周りの修正

確認お願いします。

補足

  • 確認する際は、node_modulesを一度削除した方が良いかも
  • アップデートに伴い、以前まではタブでCanvasとDocsを切り替えていたが、別々のページとして切り出された(なぜ?)

@takashi0602 takashi0602 self-assigned this Jul 13, 2023
@takashi0602 takashi0602 requested a review from tyokinuhata as a code owner July 13, 2023 16:22
.babelrc Show resolved Hide resolved
.eslintignore Show resolved Hide resolved
next.config.js Show resolved Hide resolved
package.json Show resolved Hide resolved
src/components/base/Badge/index.stories.tsx Show resolved Hide resolved
src/components/base/Text/styles.css.ts Show resolved Hide resolved
src/components/base/Text/styles.css.ts Show resolved Hide resolved
.storybook/main.ts Show resolved Hide resolved
.storybook/preview.tsx Show resolved Hide resolved
package.json Show resolved Hide resolved
package.json Show resolved Hide resolved
package.json Show resolved Hide resolved
src/components/base/Text/index.tsx Show resolved Hide resolved
src/styles/themes.css.ts Show resolved Hide resolved
src/styles/themes.css.ts Show resolved Hide resolved
@tyokinuhata
Copy link
Member

tyokinuhata commented Jul 14, 2023

Chromaticに出てるこの差分って #267 かな?

@tyokinuhata
Copy link
Member

Storybook v7、UI自体はそんなに変わらんすね

@tyokinuhata tyokinuhata mentioned this pull request Jul 14, 2023
@takashi0602
Copy link
Member Author

takashi0602 commented Jul 14, 2023

Chromaticに出てるこの差分って #267 かな?

これっすね、全然ホバー関係なかった😇
ので、issue書き換えました

これは別PRで調査と対応します🫡

@tyokinuhata tyokinuhata merged commit 4c97302 into main Jul 14, 2023
@tyokinuhata tyokinuhata deleted the chore/167_update-storybook branch July 14, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants