Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ts-nodeを導入 #246

Merged
merged 8 commits into from
Jul 17, 2023
Merged

ts-nodeを導入 #246

merged 8 commits into from
Jul 17, 2023
+774 −830

Conversation

tyokinuhata
Copy link
Member

@tyokinuhata tyokinuhata commented Jun 26, 2023 •
edited
Loading

@tyokinuhata tyokinuhata added the enhancement New feature or request label Jun 26, 2023
@tyokinuhata tyokinuhata self-assigned this Jun 26, 2023
@tyokinuhata tyokinuhata requested a review from takashi0602 as a code owner June 26, 2023 18:51
@uyupunpopunpo
Copy link
Contributor

Storybook URL: https://uyupun.github.io/official/feat_ts_node/storybook/
Lighthouse URL: https://uyupun.github.io/official/feat_ts_node/lighthouse/

@tyokinuhata
Copy link
Member Author

tyokinuhata commented Jun 26, 2023 •
edited
Loading

Storybook周りで失敗している: https://github.com/uyupun/official/actions/runs/5381910641

@tyokinuhata
Copy link
Member Author

関連issue?: storybookjs/storybook#11587

@tyokinuhata
Copy link
Member Author

関連issue?: RyanClementsHax/storybook-addon-next#28

@tyokinuhata
Copy link
Member Author

tyokinuhata commented Jun 26, 2023 •
edited
Loading

storybook-addon-nextがESMをサポートしておらず、next.config.jsを読み込めない + 仮にnext.config.cjsに変更したところでstorybook-addon-nextからファイルを見つけられない という二重のエラー

@tyokinuhata
Copy link
Member Author

このissue対応してからのほうが良さそう: #225

@tyokinuhata
Copy link
Member Author

来月のマイルストーンに入っているのでそれまで待つでも良さそう

@tyokinuhata
Copy link
Member Author

.storybook/main.jsから明示的にNextConfigのファイル名を指定できれば暫定処置はできるのかなという印象です

@takashi0602
Copy link
Member

対応あざます🙏
Storybookのバージョンアップデート＋@storybook/nextjsの導入後に対応の方が二度手間にならなくて済みそうなので、一旦Draftとして待ちが良さそうかな🤔
（ただ、上記対応しても読み込めないみたいなこともありそう...）

@tyokinuhata
Copy link
Member Author

そうっすね、一旦Storybook周りのアップデート待ちでこのPRはDraftにします
Storybook周りの対応完了後、マージして対応します

@tyokinuhata tyokinuhata marked this pull request as draft June 27, 2023 01:37
@tyokinuhata
Copy link
Member Author

とりあえず #269 マージ前のコンフリクトだけ先に修正

@tyokinuhata
Copy link
Member Author

Storybookも動作するようになっていました

@tyokinuhata tyokinuhata marked this pull request as ready for review July 14, 2023 16:31
takashi0602
takashi0602 previously approved these changes Jul 17, 2023
View reviewed changes
Copy link
Member

@takashi0602 takashi0602 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ちょっと気になったところ1件だけコメントしてますが、全コマンドも動くんでApproveします！
LGTM👍

package.json Outdated
Comment on lines 67 to 69
"ts-node": "^10.9.1",
"typescript": "4.9.5",
"storybook": "^7.0.26",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

名前順だとStorybookがts-nodeよりも上に来るきがする🤔

Suggested change
"ts-node": "^10.9.1",
"typescript": "4.9.5",
"storybook": "^7.0.26",
"storybook": "^7.0.26",
"ts-node": "^10.9.1",
"typescript": "4.9.5",

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

そういう順なのかこれｗ

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

69c55bd で対応しました

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

あざます！
特に自分でpackage.jsonに記述せずに、コマンドからインストールする場合は基本名前順としてpackage.jsonに記述されていくんですよ（多分今回コンフリクト起こしてて、明記したからかな〜という予想）

takashi0602
takashi0602 approved these changes Jul 17, 2023
View reviewed changes
Copy link
Member

@takashi0602 takashi0602 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

対応あざました🥰

@tyokinuhata tyokinuhata merged commit 493bb72 into main Jul 17, 2023
@tyokinuhata tyokinuhata deleted the feat/ts_node branch July 17, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takashi0602 takashi0602 takashi0602 approved these changes

Assignees

@tyokinuhata tyokinuhata

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tyokinuhata @uyupunpopunpo @takashi0602