-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Post Resume images in threads #449
Conversation
src/events/messageCreate.ts
Outdated
// Send the image back to the channel | ||
const preview_message = await message.channel.send({ | ||
// Send the image back to the channel as a thread | ||
const botMessage = await message.channel.send('Converting Resume...'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good if the thread could be created from the message containing the PDF file, instead of from this newly sent message.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with this as well.
src/events/messageCreate.ts
Outdated
// Send the image back to the channel | ||
const preview_message = await message.channel.send({ | ||
// Send the image back to the channel as a thread | ||
const botMessage = await message.channel.send('Converting Resume...'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with this as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Nice work!
Summary of Changes
Resume image conversions are now posted in a separate thread. Resolves #427.